Nametags: Add TOTEM_POP_COUNT ContentType #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows for the popped totems to be able to be shown in the nametags. The totem pop counting functionality is embedded in the TotemPopCounter module, hence, it needs to be active in order for this to work. As to ensure this is the case, this patch adds some logic preventing this feature to be enabled when the TotemPopCounter module is inactive, and also re-enables the TotemPopCounter module if this feature is enabled and the user tries to disable the TotemPopCounter module.
Avanatiker
approved these changes
Jan 8, 2023
|
I removed your consumer and now we just make nametags force enable TotemPopCounter while its needed. Thanks for this pull :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows for the popped totems to be able to be shown in the nametags. The totem pop counting functionality is embedded in the TotemPopCounter module, hence, it needs to be active in order for this to work.
As to ensure this is the case, this patch adds some logic preventing this feature to be enabled when the TotemPopCounter module is inactive, and also re-enables the TotemPopCounter module if this feature is enabled and the user tries to disable the TotemPopCounter module.
EDIT: This is a tiny bit hacky and in the future it could be greatly benefited by a refactor that separates the popped totem counting logic from the TotemPopCounter module, but I believe this works quite OK for now :))