Added copy/paste in module options #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfresh2
reviewed
Feb 11, 2023
Comment on lines
68
to
77
| Keyboard.KEY_V, Keyboard.KEY_INSERT -> { | ||
| if (!GuiScreen.isCtrlKeyDown() && keyCode != Keyboard.KEY_INSERT) return | ||
| componentName = GuiScreen.getClipboardString().substring(0, min(GuiScreen.getClipboardString().length - 1, 256)).replace("\n", "") | ||
| onStopListening(true) | ||
| } | ||
| Keyboard.KEY_C -> { | ||
| if (!GuiScreen.isCtrlKeyDown()) return | ||
| GuiScreen.setClipboardString(componentName) | ||
| onStopListening(true) | ||
| } |
There was a problem hiding this comment.
- Using
KEY_VandKEY_Cin thiswhencondition prevents those characters from being typed normally which only happens in theelsecondition. - The last character is cut-off when pasting.
- 256 characters is far more than what can be displayed on the gui. I can only see roughly 50 at most. I think we need to limit this down and/or have a key to clear the text box.
- I'd prefer calling
string.trim()on pasted text so leading or following spaces get cut-off. These are often mistakes in copying.
Avanatiker
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
Add a simple control v control c function into the StringButton
Describe how this pull is helpful
Copying and pasting text without having to edit the module json config file