Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Lambda API with Maven #511

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

rfresh2
Copy link
Member

@rfresh2 rfresh2 commented Mar 15, 2023

Describe the pull
Allows plugins to use Maven to pull in the lambda api jar instead of copy pasting jar's around like cavemen.

This only publishes to local maven which will be picked up by jitpack builds, this is what i'd recommended for ease of use in lieu of lambda's own maven repo.

Describe how this pull is helpful
Allow for easier updating of api jars for plugin devs. Also removes the jars as an attack vector for rogue plugin devs.

Additional context
What this would look like in a plugin's build.gradle:

dependencies {
    implementation 'com.github.rfresh2:lambda:17b1c0c842'
    ...

This of course is linked to my own repo and commit hash for example's sake.
It can be linked to the main lambda repo and a named official release after this is merged.

You can view the various versions jitpack creates by browsing here for example: https://jitpack.io/#rfresh2/lambda/

@MellDa1024
Copy link
Contributor

This looks sick 😮

Copy link
Member

@Avanatiker Avanatiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

@Avanatiker Avanatiker merged commit c79a283 into lambda-client:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants