feat: make "arbitrary" feature enable proptest features (#1355)

* Add proptest feature

* Update changelog

* Revert star import change

* Unify "proptest" feature with "arbitrary" and doc

* Update updated changelog

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 #### Upcoming Changes
 
+* feat: make *arbitrary* feature also enable a `proptest::arbitrary::Arbitrary` implementation for `Felt252` [#1355](https://github.com/lambdaclass/cairo-vm/pull/1355)
+
 * fix: correctly display invalid signature error message [#1361](https://github.com/lambdaclass/cairo-vm/pull/1361)
 
 #### [0.8.5] - 2023-7-31

felt/Cargo.toml

@@ -13,7 +13,7 @@ default = ["std"]
 std = []
 alloc = []
 lambdaworks-felt = ["dep:lambdaworks-math"]
-arbitrary = ["dep:arbitrary", "num-bigint/arbitrary"]
+arbitrary = ["dep:arbitrary", "num-bigint/arbitrary", "dep:proptest"]
 
 [dependencies]
 num-integer = { version = "0.1.45", default-features = false }
@@ -25,6 +25,7 @@ lazy_static = { version = "1.4.0", default-features = false, features = [
 serde = { version = "1.0", features = ["derive"], default-features = false }
 lambdaworks-math = { version = "0.1.2", default-features = false, optional = true }
 arbitrary = { version = "1.3.0", features = ["derive"], optional = true }
+proptest = { version = "1.2.0", optional = true }
 
 [dev-dependencies]
 proptest = "1.2.0"

felt/src/lib.rs

@@ -5,10 +5,6 @@
 #[cfg(all(not(feature = "std"), feature = "alloc"))]
 pub extern crate alloc;
 
-#[cfg(all(test, not(feature = "lambdaworks-felt")))]
-mod arbitrary_bigint_felt;
-#[cfg(all(test, feature = "lambdaworks-felt"))]
-mod arbitrary_lambdaworks;
 #[cfg(not(feature = "lambdaworks-felt"))]
 mod bigint_felt;
 #[cfg(not(feature = "lambdaworks-felt"))]
@@ -36,3 +32,11 @@ impl fmt::Display for ParseFeltError {
         write!(f, "{ParseFeltError:?}")
     }
 }
+
+#[cfg(any(feature = "arbitrary", test))]
+#[cfg_attr(feature = "lambdaworks-felt", path = "arbitrary_lambdaworks.rs")]
+#[cfg_attr(not(feature = "lambdaworks-felt"), path = "arbitrary_bigint_felt.rs")]
+/// [`proptest::arbitrary::Arbitrary`] implementation for [`Felt252`], and [`Strategy`] generating functions.
+///
+/// Not to be confused with [`arbitrary::Arbitrary`], which is also enabled by the _arbitrary_ feature.
+pub mod arbitrary;

felt/src/lib_bigint_felt.rs

@@ -1014,7 +1014,7 @@ assert_felt_impl!(Felt252);
 #[cfg(test)]
 mod test {
     use super::*;
-    use crate::{arbitrary_bigint_felt::nonzero_felt252, PRIME_STR};
+    use crate::{arbitrary::nonzero_felt252, PRIME_STR};
     use core::cmp;
     use rstest::rstest;
 

felt/src/lib_lambdaworks.rs

@@ -996,7 +996,7 @@ mod test {
     use core::cmp;
 
     use super::*;
-    use crate::{arbitrary_lambdaworks::nonzero_felt252, PRIME_STR};
+    use crate::{arbitrary::nonzero_felt252, PRIME_STR};
     use num_integer::Integer;
     use rstest::rstest;