Skip to content

Commit

Permalink
add ensure-no-std crate to workspace (#1215)
Browse files Browse the repository at this point in the history
  • Loading branch information
tdelabro authored Jun 13, 2023
1 parent f8927d9 commit f053646
Show file tree
Hide file tree
Showing 136 changed files with 762 additions and 397 deletions.
6 changes: 3 additions & 3 deletions .github/codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ coverage:
threshold: 5%

ignore:
- src/vm/errors
- src/types/errors
- vm/src/vm/errors
- vm/src/types/errors
- hint_accountant
- src/hint_processor/cairo-1-hint-processor # TODO: Remove this line
- vm/src/hint_processor/cairo-1-hint-processor # TODO: Remove this line
- ./deps
6 changes: 3 additions & 3 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,11 @@ jobs:
cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}.info --workspace --features "cairo-1-hints, test_utils"
;;
'test-no_std')
cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}.info --workspace --features test_utils --no-default-features
cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}.info --workspace --no-default-features
;;
'test-wasm')
# NOTE: release mode is needed to avoid "too many locals" error
wasm-pack test --release --node --no-default-features
wasm-pack test --release --node vm --no-default-features
;;
esac
Expand Down Expand Up @@ -423,4 +423,4 @@ jobs:
if [ ${{ matrix.program-target }} = cairo_proof_programs ]; then
PROOF=proof
fi
./src/tests/compare_vm_state.sh trace memory $PROOF
./vm/src/tests/compare_vm_state.sh trace memory $PROOF
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@

* fix: substraction of `MaybeRelocatable` always behaves as signed [#1218](https://github.com/lambdaclass/cairo-rs/pull/1218)

* move the vm in it's own directory and crate, different from the workspace

* add a `ensure_no_std` crate that will be used by the CI to check that new changes are not reverting `no_std` support

#### [0.5.1] - 2023-6-7

* fix: fix overflow for `QUAD_BIT` and `DI_BIT` hints [#1209](https://github.com/lambdaclass/cairo-rs/pull/1209)
Expand Down
Loading

1 comment on commit f053646

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: f053646 Previous: f8927d9 Ratio
add_u64_with_felt/3 2 ns/iter (± 0) 1 ns/iter (± 0) 2
add_u64_with_felt/4 2 ns/iter (± 0) 1 ns/iter (± 0) 2
add_u64_with_felt/6 4 ns/iter (± 0) 2 ns/iter (± 0) 2
add_u64_with_felt/7 4 ns/iter (± 0) 2 ns/iter (± 0) 2
add_u64_with_felt/8 3 ns/iter (± 0) 2 ns/iter (± 0) 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @unbalancedparentheses

Please sign in to comment.