-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): Implement NewHint#62 and NewHint#54 #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefontana
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 24, 2023
pefontana
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
Juan-M-V
as code owners
April 24, 2023 20:16
Benchmark Results for unmodified programs 🚀
|
pefontana
changed the title
Implement Hints #62 and #54
feat(hints): Implement NewHint#62 and NewHint#54
Apr 24, 2023
Oppen
approved these changes
Apr 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #1035 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 84 84
Lines 33375 33459 +84
=======================================
+ Hits 32735 32818 +83
- Misses 640 641 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
approved these changes
Apr 25, 2023
Oppen
approved these changes
Apr 25, 2023
MegaRedHand
pushed a commit
that referenced
this pull request
Apr 25, 2023
* Add hint code * Add cairo_programs/compute_slope_v2.cairo * add hints code * implement compute_slope_v2 * Implement VERIFY_ZERO_V3 * Add verify_zero_v3 unit tests * Add COMPUTE_SLOPE_V2 unit test * Update CHANGELOG.md * cargo clippy * Add integration test * cargo clippy
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add hint code * Add cairo_programs/compute_slope_v2.cairo * add hints code * implement compute_slope_v2 * Implement VERIFY_ZERO_V3 * Add verify_zero_v3 unit tests * Add COMPUTE_SLOPE_V2 unit test * Update CHANGELOG.md * cargo clippy * Add integration test * cargo clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Hints #62 and #54
Hint54
Hint62
Issue: #979
Checklist