-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use to_bigint to output representation as bigint #1100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 98.15% 98.15% -0.01%
==========================================
Files 85 85
Lines 34534 34514 -20
==========================================
- Hits 33897 33877 -20
Misses 637 637
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
Oppen
reviewed
May 3, 2023
Oppen
reviewed
May 3, 2023
Oppen
reviewed
May 3, 2023
Oppen
reviewed
May 3, 2023
Oppen
approved these changes
May 3, 2023
pefontana
approved these changes
May 4, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* WIP to_bigint * use to_signed_felt where necessary * correct remaining to_biguint().to_bigint() pattern * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use to_bigint to output representation as bigint.
Description
Use to_bigint to output representation as bigint and use to_signed_felt to output bigint within the [-p/2, p/2] range.
#1074.
Checklist