Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add from_bytes_(l|n)e methods #1326

Merged
merged 8 commits into from
Jul 12, 2023
Merged

feat: add from_bytes_(l|n)e methods #1326

merged 8 commits into from
Jul 12, 2023

Conversation

MegaRedHand
Copy link
Contributor

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@MegaRedHand MegaRedHand marked this pull request as ready for review July 11, 2023 14:07
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 3.669 ± 0.007 3.652 3.676 1.00
head big_factorial 3.694 ± 0.014 3.676 3.714 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.187 ± 0.021 3.160 3.219 1.00 ± 0.01
head big_fibonacci 3.174 ± 0.018 3.158 3.206 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 10.154 ± 0.124 10.083 10.489 1.00 ± 0.02
head blake2s_integration_benchmark 10.146 ± 0.184 10.011 10.619 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.512 ± 0.026 3.484 3.558 1.00 ± 0.01
head compare_arrays_200000 3.502 ± 0.020 3.481 3.548 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.381 ± 0.010 2.363 2.393 1.00
head dict_integration_benchmark 2.389 ± 0.041 2.368 2.506 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.848 ± 0.006 1.840 1.857 1.00
head field_arithmetic_get_square_benchmark 1.851 ± 0.012 1.839 1.877 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.949 ± 0.055 8.894 9.097 1.00 ± 0.01
head integration_builtins 8.928 ± 0.024 8.893 8.974 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 10.300 ± 0.101 10.196 10.452 1.01 ± 0.01
head keccak_integration_benchmark 10.231 ± 0.065 10.171 10.344 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.536 ± 0.009 3.520 3.551 1.00
head linear_search 3.551 ± 0.022 3.520 3.580 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.505 ± 0.010 2.487 2.517 1.00 ± 0.00
head math_cmp_and_pow_integration_benchmark 2.500 ± 0.005 2.493 2.509 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.302 ± 0.014 2.286 2.336 1.00 ± 0.01
head math_integration_benchmark 2.300 ± 0.007 2.287 2.308 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.019 ± 0.009 2.005 2.037 1.00
head memory_integration_benchmark 2.025 ± 0.014 2.010 2.056 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.283 ± 0.012 2.267 2.300 1.00 ± 0.01
head operations_with_data_structures_benchmarks 2.274 ± 0.018 2.254 2.317 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 820.3 ± 1.9 817.0 822.9 1.00
head pedersen 821.8 ± 2.2 818.6 825.2 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.553 ± 0.006 1.547 1.564 1.00 ± 0.00
head poseidon_integration_benchmark 1.550 ± 0.004 1.542 1.556 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.652 ± 0.045 2.626 2.777 1.01 ± 0.02
head secp_integration_benchmark 2.638 ± 0.009 2.630 2.661 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.306 ± 0.003 1.302 1.313 1.00
head set_integration_benchmark 1.311 ± 0.005 1.305 1.319 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 6.642 ± 0.060 6.578 6.774 1.00
head uint256_integration_benchmark 6.653 ± 0.075 6.573 6.824 1.00 ± 0.01

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1326 (afcf154) into main (2d5b2cc) will increase coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
+ Coverage   97.53%   97.88%   +0.35%     
==========================================
  Files          92       89       -3     
  Lines       37474    35521    -1953     
==========================================
- Hits        36549    34771    -1778     
+ Misses        925      750     -175     
Impacted Files Coverage Δ
felt/src/lib_lambdaworks.rs 97.88% <100.00%> (+0.09%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

felt/src/bigint_felt.rs Outdated Show resolved Hide resolved
@pefontana pefontana enabled auto-merge July 11, 2023 20:30
@pefontana pefontana added this pull request to the merge queue Jul 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 11, 2023
@MegaRedHand MegaRedHand added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit 013c8ba Jul 12, 2023
@MegaRedHand MegaRedHand deleted the add-from-bytes-nle branch July 12, 2023 20:08
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Add from_bytes_(l|n)e methods

* Add TODOs

* Move the new methods to `FeltOps`

* Add comment and clean up some code

* Add tests

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Add from_bytes_(l|n)e methods

* Add TODOs

* Move the new methods to `FeltOps`

* Add comment and clean up some code

* Add tests

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants