Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ensure-no_std #1825

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Fix ensure-no_std #1825

merged 5 commits into from
Aug 26, 2024

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Aug 26, 2024

Fix ensure-no_std

Description

The wasm-bindgen crate was automatically updated by a dependency, and version 0.2.93 is no longer no-std compatible. I pinned the version 0.2.92 in Cargo.toml to fix this.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Aug 26, 2024

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.728 s ±  0.042 s    [User: 25.964 s, System: 0.763 s]
  Range (min … max):   26.699 s … 26.758 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.832 s ±  0.021 s    [User: 26.066 s, System: 0.764 s]
  Range (min … max):   26.817 s … 26.847 s    2 runs
 
Summary
  'hyper_threading_main threads: 1' ran
    1.00 ± 0.00 times faster than 'hyper_threading_pr threads: 1'




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.671 s ±  0.017 s    [User: 26.186 s, System: 0.759 s]
  Range (min … max):   14.658 s … 14.683 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.737 s ±  0.000 s    [User: 26.326 s, System: 0.734 s]
  Range (min … max):   14.737 s … 14.737 s    2 runs
 
Summary
  'hyper_threading_main threads: 2' ran
    1.00 ± 0.00 times faster than 'hyper_threading_pr threads: 2'




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.938 s ±  0.265 s    [User: 38.013 s, System: 0.979 s]
  Range (min … max):   10.751 s … 11.126 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.796 s ±  0.234 s    [User: 38.270 s, System: 0.904 s]
  Range (min … max):   10.630 s … 10.961 s    2 runs
 
Summary
  'hyper_threading_pr threads: 4' ran
    1.01 ± 0.03 times faster than 'hyper_threading_main threads: 4'




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.605 s ±  0.356 s    [User: 38.513 s, System: 0.945 s]
  Range (min … max):   10.353 s … 10.857 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.665 s ±  0.062 s    [User: 38.627 s, System: 0.872 s]
  Range (min … max):   10.621 s … 10.709 s    2 runs
 
Summary
  'hyper_threading_main threads: 6' ran
    1.01 ± 0.03 times faster than 'hyper_threading_pr threads: 6'




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.537 s ±  0.009 s    [User: 38.668 s, System: 0.992 s]
  Range (min … max):   10.531 s … 10.543 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.547 s ±  0.191 s    [User: 39.098 s, System: 0.974 s]
  Range (min … max):   10.412 s … 10.682 s    2 runs
 
Summary
  'hyper_threading_main threads: 8' ran
    1.00 ± 0.02 times faster than 'hyper_threading_pr threads: 8'




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.519 s ±  0.091 s    [User: 39.399 s, System: 1.058 s]
  Range (min … max):   10.455 s … 10.584 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.498 s ±  0.120 s    [User: 39.378 s, System: 1.071 s]
  Range (min … max):   10.413 s … 10.582 s    2 runs
 
Summary
  'hyper_threading_pr threads: 16' ran
    1.00 ± 0.01 times faster than 'hyper_threading_main threads: 16'


Copy link

github-actions bot commented Aug 26, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.126 ± 0.074 2.071 2.327 1.00 ± 0.04
head big_factorial 2.124 ± 0.021 2.100 2.167 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.061 ± 0.027 2.031 2.125 1.00
head big_fibonacci 2.088 ± 0.038 2.047 2.183 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.733 ± 0.094 7.673 7.937 1.00
head blake2s_integration_benchmark 8.024 ± 0.344 7.702 8.849 1.04 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.201 ± 0.023 2.170 2.249 1.00
head compare_arrays_200000 2.212 ± 0.041 2.164 2.281 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.428 ± 0.007 1.417 1.439 1.00
head dict_integration_benchmark 1.444 ± 0.019 1.425 1.492 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.237 ± 0.017 1.216 1.275 1.00
head field_arithmetic_get_square_benchmark 1.251 ± 0.017 1.227 1.283 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.869 ± 0.162 7.689 8.218 1.00
head integration_builtins 7.965 ± 0.243 7.730 8.608 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.026 ± 0.108 7.918 8.199 1.00
head keccak_integration_benchmark 8.112 ± 0.120 7.964 8.339 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.177 ± 0.024 2.149 2.234 1.00
head linear_search 2.237 ± 0.079 2.161 2.391 1.03 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.519 ± 0.007 1.508 1.528 1.00
head math_cmp_and_pow_integration_benchmark 1.537 ± 0.041 1.509 1.619 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.453 ± 0.010 1.441 1.471 1.00 ± 0.01
head math_integration_benchmark 1.452 ± 0.018 1.439 1.500 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.213 ± 0.007 1.204 1.222 1.00
head memory_integration_benchmark 1.230 ± 0.020 1.206 1.262 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.575 ± 0.011 1.555 1.594 1.00 ± 0.02
head operations_with_data_structures_benchmarks 1.569 ± 0.029 1.546 1.647 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 527.8 ± 7.7 522.6 548.6 1.00
head pedersen 532.1 ± 10.7 523.6 553.2 1.01 ± 0.03
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 744.2 ± 4.3 739.5 754.2 1.00 ± 0.01
head poseidon_integration_benchmark 743.3 ± 5.9 737.2 754.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.855 ± 0.031 1.824 1.920 1.00
head secp_integration_benchmark 1.862 ± 0.028 1.831 1.921 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 646.9 ± 6.3 641.1 662.6 1.00
head set_integration_benchmark 649.1 ± 2.6 646.4 653.8 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.288 ± 0.042 4.243 4.348 1.00
head uint256_integration_benchmark 4.365 ± 0.069 4.277 4.534 1.02 ± 0.02

@JulianGCalderon JulianGCalderon changed the title Debug ensure_no-std Fix ensure_no-std Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (93f1f54) to head (2fe7f90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   94.90%   94.86%   -0.04%     
==========================================
  Files         102      102              
  Lines       40288    40288              
==========================================
- Hits        38234    38219      -15     
- Misses       2054     2069      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulianGCalderon JulianGCalderon marked this pull request as ready for review August 26, 2024 17:39
@JulianGCalderon JulianGCalderon changed the title Fix ensure_no-std Fix ensure-no_std Aug 26, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@JulianGCalderon JulianGCalderon added the pipelines This PR/issue is exclusively about improving our CI label Aug 26, 2024
@Oppen
Copy link
Member

Oppen commented Aug 26, 2024

The wasm-bindgen crate was automatically updated by a dependency, and version 0.2.93 is no longer no-std compatible.

Is this reported upstream? Seems like a semver violation.

@pefontana pefontana added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 1edc0b4 Aug 26, 2024
72 checks passed
@pefontana pefontana deleted the ensure-no_std-debug branch August 26, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants