Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare all contracts with dynamic layout #1840

Closed
wants to merge 2 commits into from

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Sep 18, 2024

Compare all contracts with dynamic layout

Originally in #1824, but I moved it to another PR to reduce its size

Description

Adds Makefile recipes and script to compare all contracts with dynamic layouts. Should not be added to the CI, but can be used to manually test the dynamic layouts feature thoroughly.

I don't see a reason for merging these changes, as there is now a better way to test dynamic layouts. Maybe we should close this PR.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (f2c0abb) to head (06f21e0).
Report is 19 commits behind head on dynamic-layout.

Additional details and impacted files
@@               Coverage Diff               @@
##           dynamic-layout    #1840   +/-   ##
===============================================
  Coverage           94.88%   94.88%           
===============================================
  Files                 101      101           
  Lines               39846    39846           
===============================================
  Hits                37806    37806           
  Misses               2040     2040           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.389 ± 0.026 2.354 2.442 1.00
head big_factorial 2.432 ± 0.092 2.373 2.687 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.317 ± 0.019 2.290 2.354 1.00
head big_fibonacci 2.354 ± 0.066 2.302 2.537 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.631 ± 0.155 8.403 8.837 1.00
head blake2s_integration_benchmark 8.631 ± 0.191 8.387 8.826 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.514 ± 0.103 2.429 2.684 1.02 ± 0.04
head compare_arrays_200000 2.465 ± 0.018 2.439 2.498 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.618 ± 0.012 1.607 1.650 1.00
head dict_integration_benchmark 1.623 ± 0.006 1.616 1.633 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.396 ± 0.054 1.345 1.516 1.01 ± 0.05
head field_arithmetic_get_square_benchmark 1.385 ± 0.045 1.344 1.496 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.695 ± 0.167 8.488 8.929 1.00
head integration_builtins 8.841 ± 0.336 8.526 9.612 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.948 ± 0.209 8.728 9.158 1.00
head keccak_integration_benchmark 9.041 ± 0.335 8.703 9.601 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.477 ± 0.054 2.418 2.577 1.00
head linear_search 2.514 ± 0.047 2.471 2.629 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.680 ± 0.008 1.669 1.697 1.00
head math_cmp_and_pow_integration_benchmark 1.704 ± 0.033 1.682 1.790 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.656 ± 0.015 1.639 1.693 1.00 ± 0.02
head math_integration_benchmark 1.652 ± 0.028 1.637 1.730 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.382 ± 0.008 1.372 1.395 1.00
head memory_integration_benchmark 1.388 ± 0.017 1.369 1.422 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.759 ± 0.016 1.743 1.785 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.755 ± 0.014 1.734 1.783 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 570.6 ± 4.2 564.8 578.9 1.00
head pedersen 572.9 ± 2.0 570.2 575.6 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 671.8 ± 6.2 663.2 683.5 1.00
head poseidon_integration_benchmark 679.6 ± 9.0 669.4 698.6 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.993 ± 0.028 1.966 2.062 1.00 ± 0.02
head secp_integration_benchmark 1.984 ± 0.027 1.961 2.035 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 679.6 ± 9.3 672.2 702.8 1.00 ± 0.02
head set_integration_benchmark 678.9 ± 5.5 671.3 687.5 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.814 ± 0.093 4.722 5.023 1.00 ± 0.02
head uint256_integration_benchmark 4.813 ± 0.068 4.705 4.880 1.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant