Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and deprecate to_bigint and to_biguint #757

Merged
merged 10 commits into from
Feb 14, 2023

Conversation

Juan-M-V
Copy link
Contributor

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@Juan-M-V Juan-M-V requested a review from HermanObst as a code owner February 14, 2023 12:46
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #757 (7cb731a) into main (0991fb4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files          69       69           
  Lines       28800    28825   +25     
=======================================
+ Hits        27972    27997   +25     
  Misses        828      828           
Impacted Files Coverage Δ
..._processor/builtin_hint_processor/secp/ec_utils.rs 98.98% <ø> (ø)
...ocessor/builtin_hint_processor/secp/field_utils.rs 98.73% <ø> (ø)
...processor/builtin_hint_processor/secp/signature.rs 98.67% <ø> (ø)
..._processor/builtin_hint_processor/uint256_utils.rs 100.00% <ø> (ø)
src/vm/runners/cairo_runner.rs 97.89% <ø> (ø)
felt/src/lib.rs 75.19% <100.00%> (+0.53%) ⬆️
...int_processor/builtin_hint_processor/math_utils.rs 97.37% <100.00%> (+<0.01%) ⬆️
...rocessor/builtin_hint_processor/secp/secp_utils.rs 100.00% <100.00%> (ø)
src/vm/runners/builtin_runner/ec_op.rs 98.91% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jrigada Jrigada added this pull request to the merge queue Feb 14, 2023
Merged via the queue into main with commit 2410f6b Feb 14, 2023
@Jrigada Jrigada deleted the document-biguint-conversion branch February 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants