-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hints on common/ec.cairo #888
Conversation
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 97.39% 97.41% +0.01%
==========================================
Files 69 70 +1
Lines 29279 29697 +418
==========================================
+ Hits 28516 28929 +413
- Misses 763 768 +5
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the layout "all" would need a change of name in the future
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Implements 3 new hints in common/ec_op.rs
Code for
sqrt
was taken from open PR #715This branch stems from pre-wasm/no-std-revert