Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Memory.insert argument types #902

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Change Memory.insert argument types #902

merged 3 commits into from
Mar 17, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Mar 15, 2023

Change key type from &' a K where Relocatable: TryFrom<K> to Relocatable
Change val type from &'a V to V

@fmoletta fmoletta marked this pull request as ready for review March 15, 2023 20:52
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #902 (6f1df15) into main (29e5580) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   97.38%   97.38%   -0.01%     
==========================================
  Files          69       69              
  Lines       29217    29137      -80     
==========================================
- Hits        28454    28374      -80     
  Misses        763      763              
Impacted Files Coverage Δ
..._processor/builtin_hint_processor/blake2s_utils.rs 99.74% <100.00%> (-0.01%) ⬇️
...int_processor/builtin_hint_processor_definition.rs 98.69% <100.00%> (ø)
...rocessor/builtin_hint_processor/dict_hint_utils.rs 99.22% <100.00%> (-0.01%) ⬇️
...cessor/builtin_hint_processor/find_element_hint.rs 96.73% <100.00%> (ø)
...int_processor/builtin_hint_processor/math_utils.rs 97.74% <100.00%> (-0.01%) ⬇️
...t_processor/builtin_hint_processor/memset_utils.rs 100.00% <100.00%> (ø)
...hint_processor/builtin_hint_processor/pow_utils.rs 100.00% <100.00%> (ø)
...ocessor/builtin_hint_processor/secp/field_utils.rs 98.72% <100.00%> (+<0.01%) ⬆️
..._processor/builtin_hint_processor/uint256_utils.rs 100.00% <100.00%> (ø)
src/utils.rs 99.47% <100.00%> (-0.02%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juanbono juanbono added this pull request to the merge queue Mar 17, 2023
@juanbono juanbono merged commit d448004 into main Mar 17, 2023
@juanbono juanbono deleted the insert-trait branch March 17, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants