Failing test: felt252_to_bool_bug

[igaray]

Failing program:

use array::ArrayTrait;

        fn felt_to_bool(x: felt252) -> bool {
            x == 1
        }

        fn run_test(a: felt252) -> bool {
            felt_to_bool(a)
        }

with input 1 when comparing to cairo-vm output

Test can be found in tests/boolean.rs felt252_to_bool_bug

comparing a felt252 == 1 will lead to wrong results

[azteca1998]

Running the code without --canonicalize works, therefore it's not a bug in our codebase, but rather in MLIR's. The canonicalization should always yield equivalent code, which is not the case in this bug.

I've opened an issue in the LLVM project: llvm/llvm-project#64774

[edg-l]

According to the linked pr this is fixed in a future llvm version already.