Update to LLVM 18 (and Rust 1.78) #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
force-pushed
the
update_to_llvm18
branch
2 times, most recently
from
7dbc45e
to
826c0e7
Compare
edg-l
force-pushed
the
update_to_llvm18
branch
2 times, most recently
from
9cbf1c1
to
4bb6ca5
Compare
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
|
Should be ready |
5 tasks
igaray
previously approved these changes
May 22, 2024
juanbono
reviewed
May 22, 2024
src/libfuncs/felt252.rs
Outdated
| #[test] | ||
| fn felt252_add() { | ||
| // run_program_assert_output( |
juanbono
approved these changes
May 22, 2024
igaray
approved these changes
May 22, 2024
azteca1998
approved these changes
May 22, 2024
Comment on lines
+366
to
+367
| #[cfg(not(target_arch = "x86_64"))] | ||
| const NUM_REGISTER_ARGS: usize = 8; |
There was a problem hiding this comment.
Since we don't know about other architectures I'd leave it as #[cfg(target_arch = "aarch64")] instead.
On architectures that are neither x86_64 nor aarch64 it'll fail with a compilation error. When that happens we can look into them.
| if self.invoke_data.len() & 1 != 0 { | ||
| self.invoke_data.push(0); | ||
| } | ||
| } else if self.invoke_data.len() + 1 >= 8 { | ||
| } else if self.invoke_data.len() + 1 >= NUM_REGISTER_ARGS { |
There was a problem hiding this comment.
You missed one 8 value 4 lines below this one in new_len >= 8.
| @@ -247,7 +247,7 @@ mod tests { | |||
| tag: 0, | |||
| value: JitValue::Struct { | |||
| fields: vec![JitValue::Felt252( | |||
| syscall_handler.get_block_hash(0, &mut 0).unwrap(), | |||
| syscall_handler.get_block_hash(1, &mut 0).unwrap(), | |||
There was a problem hiding this comment.
Why is this different?
There was a problem hiding this comment.
i changed the testsyscall handler to return its input, so we can test with more values
| @@ -23,7 +23,7 @@ use cairo_lang_sierra::{ | |||
| use melior::{ | |||
| dialect::{ | |||
| cf, | |||
| llvm::{self, r#type::opaque_pointer}, | |||
| llvm::{self}, | |||
There was a problem hiding this comment.
Suggested change
| llvm::{self}, | |
| llvm, |
Comment on lines
+18
to
19
| #[cfg_attr(target_arch = "x86_64", repr(C, align(16)))] | ||
| #[cfg_attr(not(target_arch = "x86_64"), repr(C, align(16)))] |
There was a problem hiding this comment.
This is no longer necessary (the cfg_attr).
Comment on lines
+25
to
26
| #[cfg_attr(target_arch = "x86_64", repr(C, align(16)))] | ||
| #[cfg_attr(not(target_arch = "x86_64"), repr(C, align(16)))] |
There was a problem hiding this comment.
This is no longer necessary (the cfg_attr).
Gerson2102
pushed a commit
to Gerson2102/cairo_native
that referenced
this pull request
May 26, 2024
* update to llvm 18 * fix clippy * fix * fix clippy * unignore felt to bool bug * unignore tests * unignore test storage_base_address_from_felt252 * fix bench script * comment sec r1 new test * fix ci * upd lockfile * update dockerfile * fix * ignore test * align to 16 on x86 * try * unwrap * fix assert * x * fix * fix get_integer_layout2 * rust 1.78 and fix array from jit * bug * Fix slice from null pointer bug. * clippy * try fix push aligned * update felt abi align * unignore test to not miss it * update runtime to use proper felt abi * evert "update runtime to use proper felt abi" This reverts commit a02993e. * fix push_aligned on x86 with 16 align * format2 * unignore self referencing test * fix get_execution_info_v2 * unignore more tests * remove old todo * uncomment code --------- Co-authored-by: Esteve Soler Arderiu <soler.arderiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290