Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NonNull creation with a null ptr and a null ptr free in array output parsing #606

Closed
wants to merge 3 commits into from

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented May 17, 2024

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented May 17, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.256 ± 0.038 11.195 11.304 23.46 ± 0.08
cairo-native (embedded AOT) 1.498 ± 0.005 1.493 1.511 3.12 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 1.582 ± 0.006 1.574 1.593 3.30 ± 0.01
cairo-native (standalone AOT) 0.655 ± 0.004 0.651 0.664 1.36 ± 0.01
cairo-native (standalone AOT with -march=native) 0.480 ± 0.001 0.479 0.481 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.615 ± 0.030 10.576 10.680 1306.27 ± 50.51
cairo-native (embedded AOT) 1.085 ± 0.008 1.073 1.098 133.51 ± 5.23
cairo-native (embedded JIT using LLVM's ORC Engine) 1.093 ± 0.005 1.084 1.098 134.56 ± 5.22
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.04 ± 0.04
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.013 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.877 ± 0.014 1.866 1.911 28.43 ± 0.22
cairo-native (embedded AOT) 1.244 ± 0.030 1.227 1.325 18.84 ± 0.45
cairo-native (embedded JIT using LLVM's ORC Engine) 1.401 ± 0.006 1.391 1.407 21.21 ± 0.09
cairo-native (standalone AOT) 0.107 ± 0.000 0.107 0.107 1.62 ± 0.00
cairo-native (standalone AOT with -march=native) 0.066 ± 0.000 0.066 0.066 1.00

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.38%. Comparing base (511faf7) to head (b7a706a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   91.38%   91.38%   -0.01%     
==========================================
  Files         109      109              
  Lines       35889    35887       -2     
==========================================
- Hits        32797    32795       -2     
  Misses       3092     3092              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l added the review-ready A PR that is ready for review label May 17, 2024
@edg-l
Copy link
Collaborator Author

edg-l commented May 22, 2024

i think if #566 is merged this will not be needed since it also applies the fix

@igaray
Copy link
Collaborator

igaray commented May 23, 2024

Made redundant by #566

@igaray igaray closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants