-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix NonNull creation with a null ptr and a null ptr free in array output parsing #606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
May 17, 2024 10:24
edg-l
force-pushed
the
fix-array-empty-free
branch
from
May 17, 2024 10:25
99b6ef0
to
b80c352
Compare
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.256 ± 0.038 | 11.195 | 11.304 | 23.46 ± 0.08 |
cairo-native (embedded AOT) |
1.498 ± 0.005 | 1.493 | 1.511 | 3.12 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.582 ± 0.006 | 1.574 | 1.593 | 3.30 ± 0.01 |
cairo-native (standalone AOT) |
0.655 ± 0.004 | 0.651 | 0.664 | 1.36 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.480 ± 0.001 | 0.479 | 0.481 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.615 ± 0.030 | 10.576 | 10.680 | 1306.27 ± 50.51 |
cairo-native (embedded AOT) |
1.085 ± 0.008 | 1.073 | 1.098 | 133.51 ± 5.23 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.093 ± 0.005 | 1.084 | 1.098 | 134.56 ± 5.22 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.04 ± 0.04 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.013 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.877 ± 0.014 | 1.866 | 1.911 | 28.43 ± 0.22 |
cairo-native (embedded AOT) |
1.244 ± 0.030 | 1.227 | 1.325 | 18.84 ± 0.45 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.401 ± 0.006 | 1.391 | 1.407 | 21.21 ± 0.09 |
cairo-native (standalone AOT) |
0.107 ± 0.000 | 0.107 | 0.107 | 1.62 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.066 ± 0.000 | 0.066 | 0.066 | 1.00 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 91.38% 91.38% -0.01%
==========================================
Files 109 109
Lines 35889 35887 -2
==========================================
- Hits 32797 32795 -2
Misses 3092 3092 ☔ View full report in Codecov by Sentry. |
azteca1998
approved these changes
May 22, 2024
i think if #566 is merged this will not be needed since it also applies the fix |
igaray
approved these changes
May 23, 2024
Made redundant by #566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist