Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage of the utilities module #483

Closed
igaray opened this issue Mar 18, 2024 · 7 comments · Fixed by #583
Closed

Increase coverage of the utilities module #483

igaray opened this issue Mar 18, 2024 · 7 comments · Fixed by #583
Assignees
Labels
help wanted Extra attention is needed odhack

Comments

@igaray
Copy link
Collaborator

igaray commented Mar 18, 2024

The coverage of src/utils.rs could be improved somewhat.

@igaray igaray added the odhack label Mar 18, 2024
@igaray igaray added this to Starknet Mar 18, 2024
@igaray igaray moved this to Todo in Starknet Mar 18, 2024
@igaray igaray added the help wanted Extra attention is needed label Mar 18, 2024
@wugalde19
Copy link
Contributor

Hi @igaray
I'd love to start contributing on this project
Do you think this issue could be a good one to start with?
Or do you consider that maybe issues #471 or #472 could be better?

@igaray
Copy link
Collaborator Author

igaray commented Mar 18, 2024

Hi @wugalde19 ! I think this one is probably the easiest of the three. After that test_u256_div_mod_n (#472) although some knowledge of felt operations and taking a good look at how we implement them is likely required.
The issue related to byte arrays test failures (#471) is likely related to other things we are currently working on.

@wugalde19
Copy link
Contributor

@igaray Understood
In that case, I'm gonna take care of this one first
If #472 is not assigned by the moment I finish this one, then I'll take care of it as well

Thanks for the opportunity.
Please let me know if there's a chat where I can go and ask questions

@igaray
Copy link
Collaborator Author

igaray commented Mar 19, 2024

You can ask question in the Lambda Starknet telegram channel https://t.me/LambdaStarkNet

@wugalde19
Copy link
Contributor

You can ask question in the Lambda Starknet telegram channel https://t.me/LambdaStarkNet

Thanks @igaray
I just joined the channel

@tcoratger
Copy link
Collaborator

Is there anything left to do here or should we close?

@igaray igaray assigned tcoratger and unassigned wugalde19 May 15, 2024
@igaray
Copy link
Collaborator Author

igaray commented May 15, 2024

Closed by #583

@igaray igaray closed this as completed May 15, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Starknet May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed odhack
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants