Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase utils test coverage #583

Merged
merged 4 commits into from
May 17, 2024

Conversation

tcoratger
Copy link
Collaborator

Should close #483.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (d2d9cd1) to head (0526465).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   89.64%   89.87%   +0.22%     
==========================================
  Files         109      109              
  Lines       35183    35266      +83     
==========================================
+ Hits        31540    31694     +154     
+ Misses       3643     3572      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edg-l
edg-l previously approved these changes May 13, 2024
@edg-l edg-l added the review-ready A PR that is ready for review label May 13, 2024
@juanbono juanbono added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
juanbono
juanbono previously approved these changes May 14, 2024
@edg-l
Copy link
Collaborator

edg-l commented May 15, 2024

please fix conflicts

@tcoratger tcoratger dismissed stale reviews from juanbono and edg-l via 21487cf May 15, 2024 11:30
@tcoratger
Copy link
Collaborator Author

please fix conflicts

Done

juanbono
juanbono previously approved these changes May 16, 2024
azteca1998
azteca1998 previously approved these changes May 16, 2024
@juanbono
Copy link
Collaborator

Please fix conflicts @tcoratger

@tcoratger tcoratger dismissed stale reviews from azteca1998 and juanbono via 0526465 May 16, 2024 22:03
@tcoratger
Copy link
Collaborator Author

Please fix conflicts @tcoratger

Done

@juanbono juanbono added this pull request to the merge queue May 17, 2024
Merged via the queue into lambdaclass:main with commit b09410b May 17, 2024
9 checks passed
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 26, 2024
* increase utils test coverage

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase coverage of the utilities module
5 participants