-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor syscall handler meta (aka. remove it completely). #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azteca1998
requested review from
edg-l,
igaray,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
March 15, 2024 17:43
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
13.538 ± 0.062 | 13.471 | 13.637 | 31.03 ± 0.34 |
cairo-native (embedded AOT) |
1.587 ± 0.018 | 1.564 | 1.617 | 3.64 ± 0.06 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.542 ± 0.004 | 1.534 | 1.546 | 3.54 ± 0.04 |
cairo-native (standalone AOT) |
0.636 ± 0.001 | 0.634 | 0.638 | 1.46 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.436 ± 0.004 | 0.434 | 0.448 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
13.005 ± 0.026 | 12.955 | 13.046 | 1603.34 ± 19.81 |
cairo-native (embedded AOT) |
1.095 ± 0.010 | 1.085 | 1.116 | 134.96 ± 2.07 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.133 ± 0.023 | 1.102 | 1.181 | 139.68 ± 3.32 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.02 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.870 ± 0.015 | 1.853 | 1.895 | 27.56 ± 0.24 |
cairo-native (embedded AOT) |
1.228 ± 0.016 | 1.206 | 1.257 | 18.09 ± 0.25 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.456 ± 0.013 | 1.436 | 1.482 | 21.46 ± 0.21 |
cairo-native (standalone AOT) |
0.112 ± 0.000 | 0.111 | 0.112 | 1.65 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.068 ± 0.000 | 0.068 | 0.069 | 1.00 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
- Coverage 79.90% 79.51% -0.39%
==========================================
Files 111 110 -1
Lines 34248 34399 +151
==========================================
- Hits 27365 27353 -12
- Misses 6883 7046 +163 ☔ View full report in Codecov by Sentry. |
edg-l
previously approved these changes
Mar 18, 2024
5 tasks
edg-l
approved these changes
Mar 20, 2024
igaray
approved these changes
Mar 22, 2024
juanbono
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SyscallHandlerMeta
was used to store the pointer to the Starknet syscall handler. We don't need it to compile the program therefore it is unnecessary. The syscall handler is now provided to theinvoke_*
functions directly, which solves some of the issues we have with duplicatedMetadataStorage
s.Checklist