Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont use call_intrinsic, use the intrinsic directly #507

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented Apr 4, 2024

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Apr 4, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.622 ± 0.078 13.534 13.742 31.25 ± 0.20
cairo-native (embedded AOT) 1.596 ± 0.010 1.582 1.614 3.66 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 1.561 ± 0.019 1.531 1.597 3.58 ± 0.04
cairo-native (standalone AOT) 0.639 ± 0.005 0.635 0.652 1.46 ± 0.01
cairo-native (standalone AOT with -march=native) 0.436 ± 0.001 0.434 0.437 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 12.980 ± 0.034 12.945 13.036 1584.81 ± 35.12
cairo-native (embedded AOT) 1.091 ± 0.008 1.079 1.100 133.24 ± 3.07
cairo-native (embedded JIT using LLVM's ORC Engine) 1.110 ± 0.019 1.088 1.158 135.49 ± 3.77
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.010 1.01 ± 0.03
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.884 ± 0.020 1.864 1.928 27.70 ± 0.31
cairo-native (embedded AOT) 1.205 ± 0.021 1.175 1.241 17.72 ± 0.31
cairo-native (embedded JIT using LLVM's ORC Engine) 1.432 ± 0.010 1.417 1.447 21.06 ± 0.17
cairo-native (standalone AOT) 0.112 ± 0.000 0.111 0.113 1.65 ± 0.01
cairo-native (standalone AOT with -march=native) 0.068 ± 0.000 0.068 0.069 1.00

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (e571acd) to head (6793f2a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   90.28%   90.26%   -0.03%     
==========================================
  Files         107      107              
  Lines       34559    34480      -79     
==========================================
- Hits        31202    31122      -80     
- Misses       3357     3358       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanbono juanbono added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 6ae0575 Apr 8, 2024
9 checks passed
@juanbono juanbono deleted the dont_use_call_intr branch April 8, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants