Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more corelib tests #560

Merged
merged 1 commit into from
May 7, 2024
Merged

Enable more corelib tests #560

merged 1 commit into from
May 7, 2024

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented Apr 30, 2024

With this change, all the corelib tests can be ran, although some fail, but beforehand the test runner itself crashed due to missing a starknet syscall handler.

These are the remanining corelib tests that fail:

   core::test::integer_test::proper_cast - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::integer_test::special_casts::test_bounded_int_casts - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256k1_test::test_secp256k1_recover_public_key - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256k1_test::test_verify_eth_signature - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256k1_test::test_verify_eth_signature_wrong_eth_address - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256k1_test::test_verify_signature - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256k1_test::test_verify_signature_invalid_signature - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256r1_test::test_secp256r1_recover_public_key - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256r1_test::test_verify_signature - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256r1_test::test_verify_signature_invalid_signature - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256r1_test::test_verify_signature_overflowing_signature_r - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256r1_test::test_verify_signature_overflowing_signature_s - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').
   core::test::secp256r1_test::test_recover_public_key_y_even - Panicked with 0x4f7074696f6e3a3a756e77726170206661696c65642e ('Option::unwrap failed.').

fmoletta
fmoletta previously approved these changes Apr 30, 2024
azteca1998
azteca1998 previously approved these changes Apr 30, 2024
Base automatically changed from fix_segfault_snapshot_box to main May 3, 2024 09:03
@edg-l edg-l dismissed stale reviews from azteca1998 and fmoletta May 3, 2024 09:03

The base branch was changed.

Copy link

github-actions bot commented May 3, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.464 ± 0.086 13.348 13.638 30.88 ± 0.35
cairo-native (embedded AOT) 1.540 ± 0.007 1.532 1.553 3.53 ± 0.04
cairo-native (embedded JIT using LLVM's ORC Engine) 1.516 ± 0.007 1.509 1.534 3.48 ± 0.04
cairo-native (standalone AOT) 0.638 ± 0.001 0.635 0.641 1.46 ± 0.01
cairo-native (standalone AOT with -march=native) 0.436 ± 0.004 0.434 0.447 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 12.916 ± 0.066 12.854 13.064 1590.69 ± 20.72
cairo-native (embedded AOT) 1.084 ± 0.030 1.063 1.145 133.45 ± 4.00
cairo-native (embedded JIT using LLVM's ORC Engine) 1.084 ± 0.009 1.071 1.100 133.50 ± 1.93
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.02 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.830 ± 0.011 1.811 1.844 26.97 ± 0.17
cairo-native (embedded AOT) 1.188 ± 0.013 1.168 1.211 17.51 ± 0.19
cairo-native (embedded JIT using LLVM's ORC Engine) 1.439 ± 0.010 1.426 1.461 21.21 ± 0.15
cairo-native (standalone AOT) 0.112 ± 0.000 0.111 0.113 1.65 ± 0.00
cairo-native (standalone AOT with -march=native) 0.068 ± 0.000 0.068 0.068 1.00

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 6.67976% with 475 lines in your changes are missing coverage. Please review.

Project coverage is 89.18%. Comparing base (6ff093c) to head (bc9820e).

Files Patch % Lines
src/bin/cairo-native-test.rs 6.67% 475 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   89.87%   89.18%   -0.70%     
==========================================
  Files         108      108              
  Lines       34579    35080     +501     
==========================================
+ Hits        31078    31286     +208     
- Misses       3501     3794     +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l requested review from azteca1998 and fmoletta May 3, 2024 11:42
@juanbono juanbono added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 3374a98 May 7, 2024
9 checks passed
@juanbono juanbono deleted the enable_more_tests branch May 7, 2024 11:49
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants