-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more corelib tests #560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
April 30, 2024 13:26
fmoletta
previously approved these changes
Apr 30, 2024
azteca1998
previously approved these changes
Apr 30, 2024
edg-l
dismissed stale reviews from azteca1998 and fmoletta
May 3, 2024 09:03
The base branch was changed.
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
13.464 ± 0.086 | 13.348 | 13.638 | 30.88 ± 0.35 |
cairo-native (embedded AOT) |
1.540 ± 0.007 | 1.532 | 1.553 | 3.53 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.516 ± 0.007 | 1.509 | 1.534 | 3.48 ± 0.04 |
cairo-native (standalone AOT) |
0.638 ± 0.001 | 0.635 | 0.641 | 1.46 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.436 ± 0.004 | 0.434 | 0.447 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
12.916 ± 0.066 | 12.854 | 13.064 | 1590.69 ± 20.72 |
cairo-native (embedded AOT) |
1.084 ± 0.030 | 1.063 | 1.145 | 133.45 ± 4.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.084 ± 0.009 | 1.071 | 1.100 | 133.50 ± 1.93 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.02 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.830 ± 0.011 | 1.811 | 1.844 | 26.97 ± 0.17 |
cairo-native (embedded AOT) |
1.188 ± 0.013 | 1.168 | 1.211 | 17.51 ± 0.19 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.439 ± 0.010 | 1.426 | 1.461 | 21.21 ± 0.15 |
cairo-native (standalone AOT) |
0.112 ± 0.000 | 0.111 | 0.113 | 1.65 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.068 ± 0.000 | 0.068 | 0.068 | 1.00 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
- Coverage 89.87% 89.18% -0.70%
==========================================
Files 108 108
Lines 34579 35080 +501
==========================================
+ Hits 31078 31286 +208
- Misses 3501 3794 +293 ☔ View full report in Codecov by Sentry. |
azteca1998
approved these changes
May 3, 2024
azteca1998
approved these changes
May 6, 2024
juanbono
approved these changes
May 7, 2024
Gerson2102
pushed a commit
to Gerson2102/cairo_native
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, all the corelib tests can be ran, although some fail, but beforehand the test runner itself crashed due to missing a starknet syscall handler.
These are the remanining corelib tests that fail: