Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bool to use BlockExt #563

Merged
merged 6 commits into from
May 8, 2024

Conversation

RajeshRk18
Copy link
Contributor

Refactored bool libfuncs to use BlockExt

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.71%. Comparing base (bd23b1c) to head (c0eed52).
Report is 1 commits behind head on main.

Files Patch % Lines
src/libfuncs/bool.rs 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   89.74%   89.71%   -0.03%     
==========================================
  Files         108      108              
  Lines       34534    34460      -74     
==========================================
- Hits        30991    30915      -76     
- Misses       3543     3545       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igaray igaray added the odhack label May 7, 2024
@edg-l edg-l added this pull request to the merge queue May 8, 2024
Merged via the queue into lambdaclass:main with commit 1bbda33 May 8, 2024
9 checks passed
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 15, 2024
* Refactor

* Ran fmt and check

* Ran make check

---------

Co-authored-by: Iñaki Garay <igarai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants