Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dict gas #567

Merged
merged 3 commits into from
May 3, 2024
Merged

fix: dict gas #567

merged 3 commits into from
May 3, 2024

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented May 3, 2024

Resolves #289

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link
Collaborator

@azteca1998 azteca1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@edg-l edg-l added this pull request to the merge queue May 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (4e1b12a) to head (157f03d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   89.71%   89.74%   +0.02%     
==========================================
  Files         108      108              
  Lines       34457    34534      +77     
==========================================
+ Hits        30914    30991      +77     
  Misses       3543     3543              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into lambdaclass:main with commit bd23b1c May 3, 2024
9 checks passed
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 15, 2024
* update runtime bindings of dict

* update build_squash include gas refund

* unskip tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dictionary gas counting
4 participants