Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor and util for OptLevel #570

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

tcoratger
Copy link
Collaborator

  • Small refactor
  • Implementation of (in order to reduce duplicated code):
    • From<usize> for OptLevel
    • Into<usize> for OptLevel
    • From<u8> for OptLevel

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 89.74%. Comparing base (9a3e2ed) to head (a93b64b).
Report is 1 commits behind head on main.

Files Patch % Lines
src/ffi.rs 42.85% 12 Missing ⚠️
src/bin/cairo-native-run.rs 0.00% 2 Missing ⚠️
src/bin/cairo-native-compile.rs 0.00% 1 Missing ⚠️
src/bin/cairo-native-test.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   89.73%   89.74%           
=======================================
  Files         108      108           
  Lines       34532    34528    -4     
=======================================
- Hits        30989    30987    -2     
+ Misses       3543     3541    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igaray igaray added this pull request to the merge queue May 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@igaray igaray added the priority label May 7, 2024
@juanbono juanbono added this pull request to the merge queue May 7, 2024
Merged via the queue into lambdaclass:main with commit 0145156 May 7, 2024
9 checks passed
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 15, 2024
* Small refactor and util for OptLevel

* fix clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants