some refactoring #574
Merged
some refactoring #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
edg-l,
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 109 109
Lines 34621 34621
=======================================
Hits 30406 30406
Misses 4215 4215 ☔ View full report in Codecov by Sentry. |
juanbono
reviewed
May 7, 2024
juanbono
previously approved these changes
May 8, 2024
pefontana
requested changes
May 8, 2024
There was a problem hiding this comment.
Thanks for the contribution @tcoratger !
If you restore the deleted types we can merge it!
tcoratger
commented
May 8, 2024
Done |
pefontana
approved these changes
May 13, 2024
juanbono
approved these changes
May 13, 2024
Gerson2102
pushed a commit
to Gerson2102/cairo_native
that referenced
this pull request
May 15, 2024
* refactor collect instructions * Update src/libfuncs/enum.rs * Update benches/util.rs * Update src/compiler.rs * Update src/compiler.rs * Update src/compiler.rs * Update src/debug_info.rs * Update src/debug_info.rs * Update src/debug_info.rs * Update src/libfuncs/enum.rs * update --------- Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com> Co-authored-by: Edgar <git@edgarluque.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactorings are made on the following points:
collectare avoided because they are inferred automatically.Felt::from(1)is replaced by the dedicated constantFelt::ONEFelt::from(0)is replaced by the dedicated constantFelt::ZEROChecklist