Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export cairo vm programs #586

Merged
merged 4 commits into from
May 14, 2024
Merged

Export cairo vm programs #586

merged 4 commits into from
May 14, 2024

Conversation

pefontana
Copy link
Collaborator

@pefontana pefontana commented May 13, 2024

Export cairo vm programs to test
https://github.com/lambdaclass/cairo-vm/tree/main/cairo_programs/cairo-1-programs

Failed tests were commented

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented May 13, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.387 ± 0.085 11.282 11.535 26.16 ± 0.21
cairo-native (embedded AOT) 1.587 ± 0.018 1.573 1.633 3.65 ± 0.04
cairo-native (embedded JIT using LLVM's ORC Engine) 1.565 ± 0.023 1.534 1.611 3.59 ± 0.05
cairo-native (standalone AOT) 0.638 ± 0.005 0.635 0.650 1.47 ± 0.01
cairo-native (standalone AOT with -march=native) 0.435 ± 0.001 0.434 0.436 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.698 ± 0.059 10.620 10.794 1317.17 ± 15.70
cairo-native (embedded AOT) 1.093 ± 0.009 1.078 1.105 134.57 ± 1.80
cairo-native (embedded JIT using LLVM's ORC Engine) 1.119 ± 0.013 1.108 1.154 137.74 ± 2.16
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.02 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.008 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.902 ± 0.019 1.883 1.931 28.01 ± 0.28
cairo-native (embedded AOT) 1.274 ± 0.018 1.250 1.299 18.76 ± 0.27
cairo-native (embedded JIT using LLVM's ORC Engine) 1.454 ± 0.007 1.442 1.469 21.40 ± 0.11
cairo-native (standalone AOT) 0.112 ± 0.000 0.111 0.112 1.64 ± 0.00
cairo-native (standalone AOT with -march=native) 0.068 ± 0.000 0.068 0.068 1.00

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (4ca09c2) to head (9062c54).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
+ Coverage   88.54%   88.63%   +0.09%     
==========================================
  Files         109      109              
  Lines       34905    34905              
==========================================
+ Hits        30906    30938      +32     
+ Misses       3999     3967      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l added the review-ready A PR that is ready for review label May 14, 2024
@edg-l edg-l enabled auto-merge May 14, 2024 11:01
@edg-l edg-l added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit e89d38a May 14, 2024
9 checks passed
@edg-l edg-l deleted the export-cairo-vm-programs branch May 14, 2024 12:17
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 15, 2024
* Add cairo-vm tests

* Comment failing tests

* Add doc

---------

Co-authored-by: Pedro Fontana <peter@Pedros-MacBook-Pro.local>
@pefontana pefontana mentioned this pull request May 29, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants