increase test coverage of cairo-native-run
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
edg-l,
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
|
@edg-l Concerning |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
+ Coverage 88.63% 89.03% +0.39%
==========================================
Files 109 109
Lines 34905 35174 +269
==========================================
+ Hits 30938 31316 +378
+ Misses 3967 3858 -109 ☔ View full report in Codecov by Sentry. |
edg-l
previously approved these changes
May 14, 2024
juanbono
reviewed
May 14, 2024
src/bin/cairo-native-run.rs
Outdated
| let felt = jitvalue_to_felt(value); | ||
| felts.extend(felt); | ||
| let mut felts = vec![(*tag).into()]; | ||
| // felts.push((*tag).into()); |
There was a problem hiding this comment.
Why did you comment that line?
There was a problem hiding this comment.
Sorry, we can just remove it as the vec is initialized on the line before with the tag. Just fixed
juanbono
approved these changes
May 14, 2024
tcoratger
commented
May 14, 2024
juanbono
approved these changes
May 16, 2024
edg-l
approved these changes
May 17, 2024
Gerson2102
pushed a commit
to Gerson2102/cairo_native
that referenced
this pull request
May 26, 2024
* increase test coverage of cairo-native-run * add unit tests for result_to_runresult * Update src/bin/cairo-native-run.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist