Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase test coverage of cairo-native-test #597

Merged
merged 2 commits into from
May 17, 2024

Conversation

tcoratger
Copy link
Collaborator

Increase test coverage of cairo-native-test:

  • secp256r1 operations
  • secp256k1 operations

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 97.23618% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 90.33%. Comparing base (dadd891) to head (7d43fd9).
Report is 2 commits behind head on main.

Files Patch % Lines
src/bin/cairo-native-test.rs 97.23% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   89.13%   90.33%   +1.19%     
==========================================
  Files         109      109              
  Lines       34960    35306     +346     
==========================================
+ Hits        31161    31892     +731     
+ Misses       3799     3414     -385     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanbono juanbono added the review-ready A PR that is ready for review label May 15, 2024
@juanbono juanbono added this pull request to the merge queue May 17, 2024
Merged via the queue into lambdaclass:main with commit 6597763 May 17, 2024
9 checks passed
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants