-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all corelib tests, use corelib in CI #622
Conversation
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.310 ± 0.057 | 11.246 | 11.462 | 23.56 ± 0.13 |
cairo-native (embedded AOT) |
1.496 ± 0.009 | 1.485 | 1.511 | 3.12 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.630 ± 0.025 | 1.594 | 1.681 | 3.40 ± 0.05 |
cairo-native (standalone AOT) |
0.653 ± 0.002 | 0.651 | 0.658 | 1.36 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.480 ± 0.001 | 0.479 | 0.482 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.598 ± 0.048 | 10.515 | 10.647 | 1305.77 ± 15.67 |
cairo-native (embedded AOT) |
1.096 ± 0.014 | 1.081 | 1.116 | 134.98 ± 2.32 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.092 ± 0.006 | 1.081 | 1.101 | 134.52 ± 1.69 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.04 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.866 ± 0.009 | 1.851 | 1.880 | 28.25 ± 0.16 |
cairo-native (embedded AOT) |
1.229 ± 0.005 | 1.220 | 1.235 | 18.61 ± 0.10 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.401 ± 0.007 | 1.389 | 1.412 | 21.21 ± 0.13 |
cairo-native (standalone AOT) |
0.107 ± 0.000 | 0.107 | 0.107 | 1.62 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.066 ± 0.000 | 0.066 | 0.067 | 1.00 |
Status TRACE cairo_native_test::utils::test: running test "core::test::secp256k1_test::test_verify_signature" segfaults on some linux systems |
✅ Code is now correctly formatted. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 91.87% 91.84% -0.04%
==========================================
Files 113 115 +2
Lines 34584 34422 -162
==========================================
- Hits 31775 31614 -161
+ Misses 2809 2808 -1 ☔ View full report in Codecov by Sentry. |
Depends on #619, supersedes (it implements the coupon libfuncs too) #621
Checklist