Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored sint32 to use the BlockExt trait #664

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

tcoratger
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@tcoratger tcoratger changed the title Refactored enum sint32 to use the BlockExt trait Refactored sint32 to use the BlockExt trait Jun 4, 2024
fmoletta
fmoletta previously approved these changes Jun 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 96.38554% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (b2f1568) to head (033cdbb).
Report is 12 commits behind head on main.

Files Patch % Lines
src/libfuncs/sint32.rs 96.38% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   91.95%   91.83%   -0.13%     
==========================================
  Files         112      115       +3     
  Lines       34265    34288      +23     
==========================================
- Hits        31509    31489      -20     
- Misses       2756     2799      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azteca1998 azteca1998 added this pull request to the merge queue Jun 6, 2024
Merged via the queue into lambdaclass:main with commit 9424e67 Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants