Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dict deserialization. #672

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Fix dict deserialization. #672

merged 6 commits into from
Jun 6, 2024

Conversation

azteca1998
Copy link
Collaborator

@azteca1998 azteca1998 commented Jun 5, 2024

Steps to fix:

  • Make the dict deserialization match the box's implementation.
  • Realize every test that returns dictionaries fails except the one that returns only a dictionary (not a tuple containing dictionaries).
  • Fix the JitValue::from_jit so that every test passes except the one that was passing before.
  • Fix the parse_result implementation so that the dict-only return test also passes.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@azteca1998 azteca1998 marked this pull request as ready for review June 5, 2024 14:03
Copy link

github-actions bot commented Jun 5, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.334 ± 0.053 11.277 11.429 23.60 ± 0.12
cairo-native (embedded AOT) 1.525 ± 0.012 1.508 1.546 3.17 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 1.620 ± 0.013 1.601 1.648 3.37 ± 0.03
cairo-native (standalone AOT) 0.654 ± 0.004 0.651 0.664 1.36 ± 0.01
cairo-native (standalone AOT with -march=native) 0.480 ± 0.001 0.480 0.481 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.697 ± 0.062 10.613 10.826 1317.24 ± 18.37
cairo-native (embedded AOT) 1.113 ± 0.013 1.099 1.134 137.10 ± 2.38
cairo-native (embedded JIT using LLVM's ORC Engine) 1.131 ± 0.009 1.121 1.146 139.25 ± 2.11
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.010 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.897 ± 0.011 1.885 1.921 28.71 ± 0.18
cairo-native (embedded AOT) 1.263 ± 0.009 1.247 1.279 19.12 ± 0.14
cairo-native (embedded JIT using LLVM's ORC Engine) 1.439 ± 0.010 1.423 1.455 21.78 ± 0.15
cairo-native (standalone AOT) 0.107 ± 0.000 0.107 0.108 1.62 ± 0.00
cairo-native (standalone AOT with -march=native) 0.066 ± 0.000 0.066 0.066 1.00

edg-l
edg-l previously approved these changes Jun 5, 2024
@edg-l edg-l added the review-ready A PR that is ready for review label Jun 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (eacacf7) to head (02e0002).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   91.82%   91.84%   +0.01%     
==========================================
  Files         115      115              
  Lines       34254    34268      +14     
==========================================
+ Hits        31455    31474      +19     
+ Misses       2799     2794       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azteca1998 azteca1998 linked an issue Jun 5, 2024 that may be closed by this pull request
edg-l
edg-l previously approved these changes Jun 5, 2024
@edg-l edg-l enabled auto-merge June 6, 2024 13:37
@edg-l edg-l added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit e90c4ce Jun 6, 2024
9 checks passed
@edg-l edg-l deleted the fix-dict-deserialization branch June 6, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nullable_box_vec.cairo error
4 participants