Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issues templates #809

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Add issues templates #809

merged 3 commits into from
Sep 27, 2024

Conversation

pefontana
Copy link
Collaborator

No description provided.

@pefontana pefontana changed the title Update issue templates Add issues templates Sep 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (d124199) to head (a67e23a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files         122      122           
  Lines       34169    34169           
=======================================
  Hits        30087    30087           
  Misses       4082     4082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 25, 2024

Benchmark results Main vs HEAD

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.270 ± 0.030 3.225 3.317 1.01 ± 0.01
base factorial_2M.cairo (JIT) 3.261 ± 0.049 3.216 3.380 1.00 ± 0.02
head factorial_2M.cairo (AOT) 3.252 ± 0.034 3.196 3.316 1.00 ± 0.01
base factorial_2M.cairo (AOT) 3.245 ± 0.032 3.194 3.311 1.00
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.789 ± 0.030 2.752 2.835 1.01 ± 0.02
base fib_2M.cairo (JIT) 2.784 ± 0.022 2.744 2.811 1.01 ± 0.02
head fib_2M.cairo (AOT) 2.768 ± 0.020 2.742 2.808 1.00 ± 0.02
base fib_2M.cairo (AOT) 2.763 ± 0.038 2.707 2.847 1.00
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.204 ± 0.026 3.178 3.269 1.05 ± 0.01
base logistic_map.cairo (JIT) 3.176 ± 0.026 3.126 3.217 1.05 ± 0.01
head logistic_map.cairo (AOT) 3.045 ± 0.023 3.013 3.085 1.00 ± 0.01
base logistic_map.cairo (AOT) 3.038 ± 0.021 3.016 3.089 1.00

edg-l
edg-l previously approved these changes Sep 26, 2024
Comment on lines 21 to 23
* What project are you running
* Which Cairo, Sierra, or Starknet transaction are you running
* What Error are you getting
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also request the exact commands for reproducing the bug as well as a minimal example in cases where it makes sense? (maybe a contract is impossible to reduce but if it's a libfunc there should be a minimal example).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!
Good advice @azteca1998



**Desktop (please complete the following information):**
- OS: [e.g. MacOS, Ubuntu 22.04 LTS]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should also provide their architecture (x86_64 or aarch64), not only their OS since we have quite a bit of architecture-dependent code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
done

Copy link

github-actions bot commented Sep 26, 2024

Benchmark results Main vs HEAD

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.387 ± 0.054 3.319 3.503 1.02 ± 0.02
base factorial_2M.cairo (JIT) 3.386 ± 0.024 3.345 3.417 1.01 ± 0.02
head factorial_2M.cairo (AOT) 3.355 ± 0.036 3.314 3.438 1.01 ± 0.02
base factorial_2M.cairo (AOT) 3.336 ± 0.053 3.218 3.399 1.00
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.787 ± 0.037 2.747 2.863 1.01 ± 0.02
base fib_2M.cairo (JIT) 2.772 ± 0.024 2.742 2.811 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.769 ± 0.015 2.752 2.793 1.01 ± 0.01
base fib_2M.cairo (AOT) 2.752 ± 0.024 2.719 2.806 1.00
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.169 ± 0.023 3.134 3.209 1.06 ± 0.01
base logistic_map.cairo (JIT) 3.144 ± 0.009 3.126 3.158 1.05 ± 0.01
head logistic_map.cairo (AOT) 3.007 ± 0.027 2.962 3.047 1.01 ± 0.01
base logistic_map.cairo (AOT) 2.989 ± 0.019 2.960 3.012 1.00

@edg-l edg-l added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit e98613c Sep 27, 2024
15 checks passed
@edg-l edg-l deleted the pefontana-issues-template branch September 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants