Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot clones #812

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Fix snapshot clones #812

merged 4 commits into from
Sep 27, 2024

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Sep 26, 2024

Benchmark results Main vs HEAD

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.130 ± 0.025 3.091 3.160 1.00 ± 0.01
base factorial_2M.cairo (JIT) 3.136 ± 0.018 3.110 3.165 1.00 ± 0.01
head factorial_2M.cairo (AOT) 3.123 ± 0.035 3.093 3.209 1.00 ± 0.01
base factorial_2M.cairo (AOT) 3.122 ± 0.026 3.099 3.164 1.00
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.678 ± 0.014 2.661 2.700 1.01 ± 0.01
base fib_2M.cairo (JIT) 2.679 ± 0.026 2.643 2.731 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.673 ± 0.015 2.655 2.702 1.01 ± 0.01
base fib_2M.cairo (AOT) 2.653 ± 0.012 2.634 2.671 1.00
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.078 ± 0.018 3.045 3.099 1.05 ± 0.01
base logistic_map.cairo (JIT) 3.083 ± 0.021 3.046 3.126 1.05 ± 0.01
head logistic_map.cairo (AOT) 2.935 ± 0.024 2.912 2.992 1.00 ± 0.01
base logistic_map.cairo (AOT) 2.931 ± 0.022 2.891 2.958 1.00

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (e98613c) to head (a515a28).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files         122      122           
  Lines       34169    34165    -4     
=======================================
- Hits        30087    30084    -3     
+ Misses       4082     4081    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azteca1998 azteca1998 marked this pull request as ready for review September 26, 2024 16:15
@edg-l edg-l added the review-ready A PR that is ready for review label Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

Benchmark results Main vs HEAD

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.131 ± 0.021 3.104 3.169 1.00
base factorial_2M.cairo (JIT) 3.151 ± 0.017 3.126 3.179 1.01 ± 0.01
head factorial_2M.cairo (AOT) 3.153 ± 0.035 3.105 3.210 1.01 ± 0.01
base factorial_2M.cairo (AOT) 3.165 ± 0.025 3.132 3.208 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.670 ± 0.011 2.651 2.687 1.00
base fib_2M.cairo (JIT) 2.714 ± 0.014 2.703 2.745 1.02 ± 0.01
head fib_2M.cairo (AOT) 2.682 ± 0.016 2.650 2.702 1.00 ± 0.01
base fib_2M.cairo (AOT) 2.682 ± 0.019 2.662 2.729 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.092 ± 0.020 3.062 3.137 1.05 ± 0.01
base logistic_map.cairo (JIT) 3.120 ± 0.025 3.082 3.161 1.06 ± 0.01
head logistic_map.cairo (AOT) 2.949 ± 0.014 2.924 2.962 1.00
base logistic_map.cairo (AOT) 2.958 ± 0.011 2.947 2.985 1.00 ± 0.01

@azteca1998 azteca1998 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 3d4c858 Sep 27, 2024
15 checks passed
@azteca1998 azteca1998 deleted the fix-snapshot-clones branch September 27, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants