Fix process block bug

[JulianGCalderon]

Fixes #845, in conjunction with lambdaclass/sequencer#11.

wrap_sha256_process_block syscall should modify the received state with the new state, but instead of doing this, it copies the value and modifies the copied version, leaving the old state untouched.

This PR fixes it.

All transactions mentioned in the issue are now working correctly.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.43%. Comparing base (8175154) to head (e10c0d2).

Files with missing lines	Patch %	Lines
src/starknet.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   82.43%   82.43%   -0.01%     
==========================================
  Files         120      120              
  Lines       34856    34857       +1     
==========================================
  Hits        28733    28733              
- Misses       6123     6124       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
Cairo-vm (Rust, Cairo 1)	10.766 ± 0.247	10.531	11.282	22.78 ± 0.54
cairo-native (embedded AOT)	3.166 ± 0.025	3.138	3.211	6.70 ± 0.07
cairo-native (embedded JIT using LLVM's ORC Engine)	3.209 ± 0.027	3.170	3.266	6.79 ± 0.07
cairo-native (standalone AOT)	0.679 ± 0.001	0.678	0.681	1.44 ± 0.01
cairo-native (standalone AOT with -march=native)	0.473 ± 0.003	0.471	0.480	1.00

Benchmark for program fib_2M

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
Cairo-vm (Rust, Cairo 1)	10.831 ± 0.274	10.378	11.222	1383.09 ± 36.33
cairo-native (embedded AOT)	2.698 ± 0.015	2.676	2.723	344.55 ± 3.13
cairo-native (embedded JIT using LLVM's ORC Engine)	2.751 ± 0.034	2.717	2.832	351.34 ± 4.98
cairo-native (standalone AOT)	0.009 ± 0.000	0.009	0.009	1.11 ± 0.01
cairo-native (standalone AOT with -march=native)	0.008 ± 0.000	0.008	0.008	1.00

Benchmark for program logistic_map

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
Cairo-vm (Rust, Cairo 1)	4.260 ± 0.038	4.214	4.318	58.97 ± 0.55
cairo-native (embedded AOT)	3.008 ± 0.018	2.980	3.034	41.64 ± 0.27
cairo-native (embedded JIT using LLVM's ORC Engine)	3.223 ± 0.057	3.149	3.297	44.62 ± 0.80
cairo-native (standalone AOT)	0.113 ± 0.001	0.113	0.116	1.57 ± 0.01
cairo-native (standalone AOT with -march=native)	0.072 ± 0.000	0.072	0.073	1.00

[github-actions]

Benchmark results Main vs HEAD.

Command	Mean [s]	Min [s]	Max [s]	Relative
head factorial_2M.cairo (JIT)	3.183 ± 0.014	3.167	3.201	1.01 ± 0.01
base factorial_2M.cairo (JIT)	3.213 ± 0.022	3.184	3.256	1.02 ± 0.01
head factorial_2M.cairo (AOT)	3.151 ± 0.022	3.134	3.209	1.00
base factorial_2M.cairo (AOT)	3.176 ± 0.021	3.153	3.227	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
head fib_2M.cairo (JIT)	2.707 ± 0.010	2.693	2.725	1.00
base fib_2M.cairo (JIT)	2.760 ± 0.049	2.704	2.851	1.02 ± 0.02
head fib_2M.cairo (AOT)	2.738 ± 0.035	2.681	2.801	1.01 ± 0.01
base fib_2M.cairo (AOT)	2.752 ± 0.023	2.718	2.792	1.02 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
head logistic_map.cairo (JIT)	3.218 ± 0.020	3.178	3.241	1.05 ± 0.01
base logistic_map.cairo (JIT)	3.285 ± 0.032	3.238	3.334	1.07 ± 0.01
head logistic_map.cairo (AOT)	3.067 ± 0.024	3.044	3.117	1.00
base logistic_map.cairo (AOT)	3.079 ± 0.053	3.000	3.148	1.00 ± 0.02

[azteca1998]

I think the following would be better:

// ...
            state: &mut [u32; 8],
            block: &[u32; 16],
        ) {
            let result = ptr.sha256_process_block(state, block, gas);
// ...