Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily block run #891

Merged
merged 34 commits into from
Nov 5, 2024
Merged

Fix daily block run #891

merged 34 commits into from
Nov 5, 2024

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Oct 30, 2024

Run Native and VM in parallel, and creates issues on failing runs

An example issue can be found here

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.99%. Comparing base (8effa98) to head (db2a04e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files         120      120           
  Lines       33866    33866           
=======================================
  Hits        28108    28108           
  Misses       5758     5758           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 30, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.977 ± 0.307 10.637 11.419 23.86 ± 0.67
cairo-native (embedded AOT) 3.254 ± 0.034 3.194 3.302 7.07 ± 0.08
cairo-native (embedded JIT using LLVM's ORC Engine) 3.208 ± 0.040 3.150 3.282 6.97 ± 0.09
cairo-native (standalone AOT) 0.662 ± 0.002 0.659 0.664 1.44 ± 0.01
cairo-native (standalone AOT with -march=native) 0.460 ± 0.001 0.459 0.463 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.159 ± 0.170 10.725 11.319 1496.16 ± 26.21
cairo-native (embedded AOT) 2.800 ± 0.039 2.736 2.864 375.45 ± 6.13
cairo-native (embedded JIT using LLVM's ORC Engine) 2.885 ± 0.035 2.854 2.954 386.76 ± 5.77
cairo-native (standalone AOT) 0.007 ± 0.000 0.007 0.008 1.00
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.008 1.08 ± 0.01

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.527 ± 0.065 4.394 4.630 63.09 ± 0.91
cairo-native (embedded AOT) 2.984 ± 0.062 2.885 3.107 41.58 ± 0.87
cairo-native (embedded JIT using LLVM's ORC Engine) 3.122 ± 0.066 3.047 3.268 43.51 ± 0.93
cairo-native (standalone AOT) 0.116 ± 0.000 0.116 0.116 1.61 ± 0.00
cairo-native (standalone AOT with -march=native) 0.072 ± 0.000 0.072 0.072 1.00

Copy link

github-actions bot commented Oct 30, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.177 ± 0.015 3.148 3.196 1.01 ± 0.01
base factorial_2M.cairo (JIT) 3.172 ± 0.018 3.142 3.200 1.01 ± 0.01
head factorial_2M.cairo (AOT) 3.166 ± 0.022 3.124 3.198 1.01 ± 0.01
base factorial_2M.cairo (AOT) 3.136 ± 0.015 3.114 3.158 1.00
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.721 ± 0.010 2.703 2.736 1.02 ± 0.01
base fib_2M.cairo (JIT) 2.726 ± 0.025 2.696 2.773 1.02 ± 0.01
head fib_2M.cairo (AOT) 2.684 ± 0.017 2.657 2.706 1.00 ± 0.01
base fib_2M.cairo (AOT) 2.679 ± 0.018 2.649 2.709 1.00
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.015 ± 0.013 2.999 3.033 1.06 ± 0.02
base logistic_map.cairo (JIT) 3.001 ± 0.013 2.979 3.022 1.05 ± 0.02
head logistic_map.cairo (AOT) 2.850 ± 0.040 2.815 2.945 1.00
base logistic_map.cairo (AOT) 2.854 ± 0.015 2.832 2.880 1.00 ± 0.02

@edg-l edg-l added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 9791075 Nov 5, 2024
30 checks passed
@edg-l edg-l deleted the fix-daily branch November 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants