-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove panics in cache #902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGCalderon
force-pushed
the
remove-panic
branch
from
November 11, 2024 19:35
98ab4ec
to
cf2b583
Compare
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.975 ± 0.171 | 10.873 | 11.454 | 8.09 ± 0.13 |
cairo-native (embedded AOT) |
3.414 ± 0.027 | 3.384 | 3.480 | 2.52 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.206 ± 0.020 | 3.166 | 3.241 | 2.36 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
1.356 ± 0.002 | 1.354 | 1.362 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.429 ± 0.301 | 10.889 | 11.762 | 141.01 ± 3.72 |
cairo-native (embedded AOT) |
2.999 ± 0.021 | 2.973 | 3.039 | 37.00 ± 0.27 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.780 ± 0.025 | 2.727 | 2.816 | 34.30 ± 0.32 |
cairo-native (standalone AOT with -march=native) |
0.081 ± 0.000 | 0.081 | 0.081 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.346 ± 0.019 | 4.319 | 4.379 | 17.93 ± 0.08 |
cairo-native (embedded AOT) |
3.122 ± 0.019 | 3.103 | 3.162 | 12.88 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.044 ± 0.019 | 3.019 | 3.085 | 12.56 ± 0.08 |
cairo-native (standalone AOT with -march=native) |
0.242 ± 0.000 | 0.242 | 0.243 | 1.00 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 83.01% 83.01% -0.01%
==========================================
Files 120 120
Lines 34313 34306 -7
==========================================
- Hits 28485 28478 -7
Misses 5828 5828 ☔ View full report in Codecov by Sentry. |
Benchmark results Main vs HEAD.
|
JulianGCalderon
requested review from
edg-l,
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
November 12, 2024 13:41
edg-l
approved these changes
Nov 12, 2024
gabrielbosio
approved these changes
Nov 12, 2024
FrancoGiachetta
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes panics from cache:
Files
Checklist