Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panics in cache #902

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Remove panics in cache #902

merged 7 commits into from
Nov 13, 2024

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Nov 11, 2024

Removes panics from cache:

Files

  • src/cache/aot.rs
  • src/cache/jit.rs

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Nov 11, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.975 ± 0.171 10.873 11.454 8.09 ± 0.13
cairo-native (embedded AOT) 3.414 ± 0.027 3.384 3.480 2.52 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 3.206 ± 0.020 3.166 3.241 2.36 ± 0.02
cairo-native (standalone AOT with -march=native) 1.356 ± 0.002 1.354 1.362 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.429 ± 0.301 10.889 11.762 141.01 ± 3.72
cairo-native (embedded AOT) 2.999 ± 0.021 2.973 3.039 37.00 ± 0.27
cairo-native (embedded JIT using LLVM's ORC Engine) 2.780 ± 0.025 2.727 2.816 34.30 ± 0.32
cairo-native (standalone AOT with -march=native) 0.081 ± 0.000 0.081 0.081 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.346 ± 0.019 4.319 4.379 17.93 ± 0.08
cairo-native (embedded AOT) 3.122 ± 0.019 3.103 3.162 12.88 ± 0.08
cairo-native (embedded JIT using LLVM's ORC Engine) 3.044 ± 0.019 3.019 3.085 12.56 ± 0.08
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.243 1.00

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (4d24686) to head (999afa9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   83.01%   83.01%   -0.01%     
==========================================
  Files         120      120              
  Lines       34313    34306       -7     
==========================================
- Hits        28485    28478       -7     
  Misses       5828     5828              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 11, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.270 ± 0.031 3.229 3.312 1.00
base factorial_2M.cairo (JIT) 3.272 ± 0.026 3.243 3.338 1.00 ± 0.01
head factorial_2M.cairo (AOT) 3.485 ± 0.019 3.452 3.509 1.07 ± 0.01
base factorial_2M.cairo (AOT) 3.409 ± 0.073 3.331 3.518 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.691 ± 0.011 2.666 2.702 1.01 ± 0.00
base fib_2M.cairo (JIT) 2.677 ± 0.008 2.665 2.690 1.00
head fib_2M.cairo (AOT) 2.880 ± 0.022 2.850 2.924 1.08 ± 0.01
base fib_2M.cairo (AOT) 2.885 ± 0.018 2.846 2.904 1.08 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 2.978 ± 0.013 2.961 3.006 1.00 ± 0.01
base logistic_map.cairo (JIT) 2.971 ± 0.014 2.952 2.992 1.00
head logistic_map.cairo (AOT) 3.063 ± 0.016 3.037 3.094 1.03 ± 0.01
base logistic_map.cairo (AOT) 3.044 ± 0.019 3.011 3.074 1.02 ± 0.01

@JulianGCalderon JulianGCalderon changed the title Remove panics Remove panics in cache Nov 11, 2024
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edg-l edg-l added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit d743d04 Nov 13, 2024
30 checks passed
@edg-l edg-l deleted the remove-panic branch November 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants