Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Transactions support for simulation #703

Merged
merged 16 commits into from
Jun 30, 2023
Merged

Transactions support for simulation #703

merged 16 commits into from
Jun 30, 2023

Conversation

mmsc2
Copy link
Contributor

@mmsc2 mmsc2 commented Jun 28, 2023

Support all the available transaction

Description

Adds support to every available transaction.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@mmsc2 mmsc2 linked an issue Jun 28, 2023 that may be closed by this pull request
@mmsc2 mmsc2 marked this pull request as ready for review June 28, 2023 23:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #703 (34d3d8f) into main (3af21ba) will increase coverage by 0.25%.
The diff coverage is 97.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   92.11%   92.37%   +0.25%     
==========================================
  Files          52       52              
  Lines       11360    11798     +438     
==========================================
+ Hits        10464    10898     +434     
- Misses        896      900       +4     
Impacted Files Coverage Δ
src/transaction/error.rs 100.00% <ø> (ø)
src/transaction/deploy_account.rs 96.92% <91.83%> (-0.87%) ⬇️
src/transaction/l1_handler.rs 96.96% <92.00%> (-0.24%) ⬇️
src/transaction/declare.rs 98.64% <93.54%> (-0.10%) ⬇️
src/transaction/declare_v2.rs 86.07% <93.87%> (+0.87%) ⬆️
src/lib.rs 98.51% <99.67%> (+0.76%) ⬆️
src/transaction/deploy.rs 99.05% <100.00%> (+0.38%) ⬆️
src/transaction/invoke_function.rs 99.32% <100.00%> (+<0.01%) ⬆️
src/transaction/mod.rs 88.09% <100.00%> (+27.22%) ⬆️

@SantiagoPittella SantiagoPittella marked this pull request as draft June 29, 2023 14:54
@SantiagoPittella SantiagoPittella marked this pull request as ready for review June 29, 2023 19:08
@SantiagoPittella SantiagoPittella changed the title Simulate declare deploy Transactions support for simulation Jun 29, 2023
@SantiagoPittella SantiagoPittella self-assigned this Jun 29, 2023
Comment on lines 349 to 352
if call_info.is_none() {
return Err(TransactionError::CallInfoIsNone);
};
let call_info = call_info.clone().unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use ok_or

@juanbono juanbono added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit f7906c3 Jun 30, 2023
@juanbono juanbono deleted the SimulateDeclareDeploy branch July 1, 2023 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulate_transaction() is limited to InvokeFunction transactions
5 participants