This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
fix: change order of arguments in fee transfer's calldata #783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #780
Description
We were passing the
Uint256
arguments in the fee transfers in big-endian order (most significative first) when in Cairo aUint256
assumes a little-endian order:This caused us to try a transfer for the original fee amount times 2**128, which in practice means a failed transaction every time.
This wasn't caught in integration tests, because they all use a gas price of 0.
This PR fixes this issue, modifies tests to use a gas price of 1, and changes error handling, so these kinds of errors can be more easily debugged.
Checklist