changed failedHash to hashError

[fguthmann]

Modified SyscallHandlerError to have a hash error of type HashError

Description

Modify the error to be clearer and give more information about the type of hash error we get.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
• Documentation has been added/updated.

[codecov-commenter]

Codecov Report

Merging #817 (a015b7a) into main (20206ef) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   91.72%   91.68%   -0.04%     
==========================================
  Files          53       54       +1     
  Lines       12421    12428       +7     
==========================================
+ Hits        11393    11395       +2     
- Misses       1028     1033       +5     

Impacted Files	Coverage Δ
src/core/errors/contract_address_errors.rs	0.00% <0.00%> (ø)
src/core/errors/hash_errors.rs	0.00% <0.00%> (ø)
src/syscalls/syscall_handler_errors.rs	100.00% <ø> (ø)
src/utils.rs	94.31% <0.00%> (ø)
src/core/transaction_hash/mod.rs	80.00% <75.00%> (-0.65%)	⬇️
src/hash_utils.rs	100.00% <100.00%> (ø)

[matias-gonz]

Good job! One comment: the hash_utils module should return HashErrors not SyscallHandler Errors, the error mapping into SyscallHandlerError should be done after calling the function

[fguthmann]

Added this translation function in ContractAdressError, is this the right way to go from ContractAddressError to HashError

`impl From<HashError> for ContractAddressError {

    fn from(error: HashError) -> Self {
        ContractAddressError::HashError(error)
    }
}`

[matias-gonz]

Nice! Could you implement a From<HashError> for SyscallHandlerError?
If not that's okay too 👍

[SantiagoPittella]

There are a couple more places where we can change the error type and use the HashError. But I think that it's good enough now. We can revisit this later.

Congrats.