Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vim-protocol work under Windows with vital lib update #3

Merged
merged 4 commits into from
Oct 10, 2021

Conversation

tsuyoshicho
Copy link
Contributor

@tsuyoshicho tsuyoshicho commented Oct 10, 2021

Problem

vim-protocol do not work under Windows.
(system curl work fine? but msys2/git for windows curl do not work)

Solution

Library update and that library include vim-jp/vital.vim#773

Web.HTTP curl/wget client outputFile did not care Path separator. This PR was fixed it same as internal tempfile handling.

related changes

  • module load method replaced, to be use vital#vim_protocol#new() instead of vital#of('vim_protocol')
  • Vim.Process replaced to Process
  • Guard.store arguments change String to List[String]

Tests result

  • Git for Windows curl http/zip/zipped file
  • Windows bundle curl http (thanks @hokorobi san)

@tsuyoshicho tsuyoshicho marked this pull request as ready for review October 10, 2021 01:41
@hokorobi
Copy link

I just loaded the URL with :e and it worked the same as before the change.
(In the case of the OS bundled curl, it seems to work fine originally.)

Windows 10, OS bundled curl, gVim 8.2.3482

@tsuyoshicho
Copy link
Contributor Author

ping @lambdalisue san

@lambdalisue lambdalisue merged commit eb9a7b9 into lambdalisue:master Oct 10, 2021
@lambdalisue
Copy link
Owner

👍

@tsuyoshicho tsuyoshicho deleted the update/vital branch October 10, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants