Replace WireMock with STTP #103
Conversation
|
|
||
| trait SttpBackendStubSpec extends ZIOSpecDefault { | ||
|
|
||
| case class StubMapping(request: Request[_, _] => Boolean, response: Response[Any]) |
There was a problem hiding this comment.
We prefer using final for case classes.
There was a problem hiding this comment.
Adding final gives me a warning during compilation:
The outer reference in this type test cannot be checked at run time. final case class StubMapping(request: Request[_, _] => Boolean, response: Response[Any])
Do you have any idea on how to get rid of this warning while keeping final ?
|
|
||
| case class StubMapping(request: Request[_, _] => Boolean, response: Response[Any]) | ||
|
|
||
| final implicit class SttpBackendStubImplicits[T](sttpBackendStub: SttpBackendStub[Task, T]) { |
There was a problem hiding this comment.
Does it make sense to use SttpBackendStubOps convention? Also, let's use [A], instead of [T]. I always feel like T is Java convention/leftover. 😄
There was a problem hiding this comment.
It makes totally sense !
| .thenRespond(stubMapping.response) | ||
| } | ||
|
|
||
| val index: IndexName = IndexName("repositories") |
There was a problem hiding this comment.
If index, repo and url can be made private we should do that.
|
|
||
| val url = "http://localhost:9200" | ||
|
|
||
| val bulkRequestStub: StubMapping = StubMapping( |
There was a problem hiding this comment.
Let's make all of those private if possible.
| getByQueryRequestStub | ||
| ) | ||
|
|
||
| val sttpBackendStubLayer: TaskLayer[SttpBackendStub[Task, Any]] = ZLayer.succeed( |
There was a problem hiding this comment.
This can be private as well, right?
…ivate in SttpBackendStubSpec
kevchuang
force-pushed
the
replace-wiremock-with-sttp
branch
from
3774cec
to
5394fbc
Compare
This PR addresses #87.