(dsl): Support prefix query #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Jun 24, 2023
| * @param field | ||
| * the type-safe field for which query is specified for | ||
| * @param value | ||
| * the value that will be used for the query, represented by an instance of type `A` |
There was a problem hiding this comment.
Suggested change
| * the value that will be used for the query, represented by an instance of type `A` | |
| * the text value that will be used for the query |
There was a problem hiding this comment.
Can you replace this for term method also?
| * @param field | ||
| * the field for which query is specified for | ||
| * @param value | ||
| * the value that will be used for the query, represented by an instance of type `A` |
| caseInsensitive: Option[Boolean] | ||
| ) extends PrefixQuery[S] { self => | ||
|
|
||
| override def caseInsensitive(value: Boolean): PrefixQuery[S] = |
| override def caseInsensitive(value: Boolean): PrefixQuery[S] = | ||
| self.copy(caseInsensitive = Some(value)) | ||
|
|
||
| override private[elasticsearch] def toJson(fieldPath: Option[String]): Json = { |
| test("prefix") { | ||
| val query = prefix(TestDocument.stringField, "test") | ||
| val queryWithCaseInsensitive = prefix(TestDocument.stringField, "test").caseInsensitiveTrue | ||
| val queryWithAllParams = prefix(TestDocument.stringField, "test").caseInsensitiveFalse |
There was a problem hiding this comment.
We have only one parameter, so queryWithAllParams is same as queryWithCaseInsensitive.
markaya
previously approved these changes
Jun 24, 2023
dbulaja98
reviewed
Jun 24, 2023
| title: "Prefix Query" | ||
| --- | ||
|
|
||
| The `Prefix` query returns documents that contain a specific prefix in a provided field. |
There was a problem hiding this comment.
Suggested change
| The `Prefix` query returns documents that contain a specific prefix in a provided field. | |
| The `Prefix` query returns documents that contain a specific prefix in the provided field. |
dbulaja98
previously approved these changes
Jun 24, 2023
drmarjanovic
requested changes
Jun 24, 2023
| @@ -2531,6 +2531,36 @@ object ElasticQuerySpec extends ZIOSpecDefault { | |||
| assert(queryWithScoreMode.toJson(fieldPath = None))(equalTo(expectedWithScoreMode.toJson)) && | |||
| assert(queryWithAllParams.toJson(fieldPath = None))(equalTo(expectedWithAllParams.toJson)) | |||
| }, | |||
| test("prefix") { | |||
There was a problem hiding this comment.
Please provide "prefix" tests in "constructing" part as well.
drmarjanovic
approved these changes
Jun 24, 2023
dbulaja98
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.