(dsl): Support sum aggregation #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitep
force-pushed
the
task-support-sum-aggregation
branch
from
5b58265
to
12a6c73
Compare
Mitep
force-pushed
the
task-support-sum-aggregation
branch
from
12a6c73
to
30d7023
Compare
markaya
suggested changes
Jun 24, 2023
Comment on lines
272
to
278
| test("sum") { | ||
| val aggregation = sumAggregation("aggregation", "testField") | ||
| val aggregationTs = sumAggregation("aggregation", TestDocument.intField) | ||
| val aggregationWithMissing = sumAggregation("aggregation", TestDocument.intField).missing(20.0) | ||
|
|
||
| val expected = | ||
| """ |
There was a problem hiding this comment.
This should be constructing
dbulaja98
requested changes
Jun 24, 2023
modules/library/src/main/scala/zio/elasticsearch/ElasticAggregation.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/ElasticAggregation.scala
Outdated
Show resolved
Hide resolved
…ation.scala Co-authored-by: Dimitrije Bulaja <dbulaja98@gmail.com>
…ation.scala Co-authored-by: Dimitrije Bulaja <dbulaja98@gmail.com>
dbulaja98
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118