Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support search with ZIO schema #32

Merged
merged 18 commits into from
Jan 12, 2023
Merged

Support search with ZIO schema #32

merged 18 commits into from
Jan 12, 2023

Conversation

markaya
Copy link
Contributor

@markaya markaya commented Dec 23, 2022

No description provided.

@markaya markaya force-pushed the dsl-support-search-with-schema branch from e83430d to 7a10abb Compare January 4, 2023 12:48
@drmarjanovic drmarjanovic changed the title [WIP] Support search with zio schema Support search with ZIO schema Jan 4, 2023
@markaya markaya force-pushed the dsl-support-search-with-schema branch from 0fec2db to 52c1de5 Compare January 5, 2023 09:23
dbulaja98
dbulaja98 previously approved these changes Jan 5, 2023
View reviewed changes
@markaya markaya force-pushed the dsl-support-search-with-schema branch from 2e2e9bf to 3c5ea0a Compare January 10, 2023 10:26
drmarjanovic
drmarjanovic requested changes Jan 10, 2023
View reviewed changes
modules/library/src/it/scala/zio/elasticsearch/HttpExecutorSpec.scala Outdated Show resolved Hide resolved
modules/library/src/it/scala/zio/elasticsearch/HttpExecutorSpec.scala Outdated Show resolved Hide resolved
modules/library/src/it/scala/zio/elasticsearch/HttpExecutorSpec.scala Outdated Show resolved Hide resolved
modules/library/src/it/scala/zio/elasticsearch/IntegrationSpec.scala Show resolved Hide resolved
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala Outdated Show resolved Hide resolved
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala Outdated Show resolved Hide resolved
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala Outdated Show resolved Hide resolved
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala Outdated Show resolved Hide resolved
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala Outdated Show resolved Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala Outdated Show resolved Hide resolved
drmarjanovic
drmarjanovic previously approved these changes Jan 11, 2023
View reviewed changes
arnoldlacko
arnoldlacko previously approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@arnoldlacko arnoldlacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can check out ForEach.partitionMap in zio-prelude, but that's more of a nice to have rather than a blocker, so approving anyway.

@markaya markaya dismissed stale reviews from arnoldlacko and drmarjanovic via 98b1a15 January 12, 2023 09:42
@drmarjanovic drmarjanovic merged commit 9a4fff3 into main Jan 12, 2023
@drmarjanovic drmarjanovic deleted the dsl-support-search-with-schema branch January 12, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbulaja98 dbulaja98 dbulaja98 requested changes

@drmarjanovic drmarjanovic drmarjanovic approved these changes

@arnoldlacko arnoldlacko arnoldlacko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markaya @drmarjanovic @arnoldlacko @dbulaja98