(dsl): Support Stats aggregation #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Nov 5, 2023
Comment on lines
250
to
251
| * an instance of [[zio.elasticsearch.aggregation.StatsAggregation]] that represents terms aggregation to be | ||
| * performed. |
There was a problem hiding this comment.
Suggested change
| * an instance of [[zio.elasticsearch.aggregation.StatsAggregation]] that represents terms aggregation to be | |
| * performed. | |
| * an instance of [[zio.elasticsearch.aggregation.StatsAggregation]] that represents stats aggregation to be | |
| * performed. |
Comment on lines
264
to
265
| * an instance of [[zio.elasticsearch.aggregation.StatsAggregation]] that represents terms aggregation to be | ||
| * performed. |
There was a problem hiding this comment.
Suggested change
| * an instance of [[zio.elasticsearch.aggregation.StatsAggregation]] that represents terms aggregation to be | |
| * performed. | |
| * an instance of [[zio.elasticsearch.aggregation.StatsAggregation]] that represents stats aggregation to be | |
| * performed. |
| title: "Stats Aggregation" | ||
| --- | ||
|
|
||
| The `Stats` aggregation is a multi-value metrics aggregation that provides statistical information (like count, sum, min, max, and average of a field) over numeric values extracted from the aggregated documents. |
There was a problem hiding this comment.
Suggested change
| The `Stats` aggregation is a multi-value metrics aggregation that provides statistical information (like count, sum, min, max, and average of a field) over numeric values extracted from the aggregated documents. | |
| The `Stats` aggregation is a multi-value metrics aggregation that provides statistical information (count, sum, min, max, and average of a field) over numeric values extracted from the aggregated documents. |
| @@ -33,8 +33,11 @@ private[elasticsearch] sealed trait ResultWithAggregation { | |||
| .map { | |||
| case Some(aggRes) => | |||
| Try(aggRes.asInstanceOf[A]) match { | |||
| case Failure(_) => Left(DecodingException(s"Aggregation with name $name was not of type you provided.")) | |||
| case Success(agg) => Right(Some(agg)) | |||
| case Failure(_) => Left(DecodingException(s"Aggregation with name $name was not of type you provided.")) | |||
There was a problem hiding this comment.
Put implementation in the new line.
| case Success(agg) => Right(Some(agg)) | ||
| case Failure(_) => Left(DecodingException(s"Aggregation with name $name was not of type you provided.")) | ||
| case Success(agg) => { | ||
| println(agg) |
vanjaftn
force-pushed
the
task-support-stats-aggregation
branch
from
af4e16b
to
31b9337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118