Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems laminas-component-installer does not install api-tools-documentation as a module #26

Closed
haclong opened this issue Jan 15, 2022 · 0 comments · Fixed by #28
Closed
Labels
Bug Something isn't working
Milestone

Comments

@haclong
Copy link

haclong commented Jan 15, 2022

Bug Report

Q A
Version(s) 1.5.x

Summary

As instructed, i have used

composer require laminas-api-tools/api-tools-documentation

the installation goes well so far but either this method does not trigger the laminas-component-installer (to be honest, i don't know how the installer is triggered / used - when it happens, it happens and if not, i'm unaware it did not be used)

Current behavior

when i go to [my domain]/api-tools/documentation, there's a error (i think it is runtime exception) saying the documentation route can not be found

How to reproduce

on a fresh install
install api-tools (eventually, you don't want the api-tools-documentation yet)
then install api-tools-documentation

Expected behavior

i am not sure it is an "expected" behaviour :

when i do composer require laminas-api-tools/api-tools-documentation-swagger, the Laminas\ApiTools\Documentation\Swagger module is automatically added to the modules.conf.php

when i do composer require laminas-api-tools/api-tools-documentation, i have to add Laminas\ApiTools\Documentation module manually to the modules.conf.php

this is not a big issue but the different behaviour between two packages by the same vendor feels strange...

@haclong haclong added the Bug Something isn't working label Jan 15, 2022
@weierophinney weierophinney added this to the 1.5.0 milestone Jan 17, 2022
weierophinney added a commit to weierophinney/api-tools-documentation that referenced this issue Jan 17, 2022
Documentation details that when used with applications that have laminas-component-installer available, this package will be auto-configured; however, the package configuration that allows that was missing.

Fixes laminas-api-tools#26

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants