Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qa/psalm #18

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Qa/psalm #18

merged 2 commits into from
Jun 10, 2021

Conversation

superrosko
Copy link
Contributor

Q A
QA yes

Description

  • Create a psalm.xml.dist in the project root
  • Copy and paste the contents from this psalm.xml.dist and fix projectFiles
  • Run $ composer --dev require vimeo/psalm
  • Run $ composer require --dev psalm/plugin-phpunit
  • Run $ vendor/bin/psalm --config=psalm.xml.dist --set-baseline=psalm-baseline.xml
  • Add a composer script static-analysis with the command psalm --shepherd --stats
  • Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
  • Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Closes #16

@superrosko superrosko changed the title feat: add psalm Qa/psalm Oct 6, 2020
@superrosko
Copy link
Contributor Author

@boesing, if the PRs is correct, then you can put a label hacktoberfest-accepted on it?

@boesing boesing added Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 31, 2020
@boesing
Copy link
Member

boesing commented Oct 31, 2020

@michalbundyra any Idea why that DB Trait thing crashes?

@boesing
Copy link
Member

boesing commented Oct 31, 2020

We need a fixed #17 in here. After this, tests should pass.

@weierophinney weierophinney added this to the 1.4.0 milestone Jun 10, 2021
@superrosko @weierophinney
feat: add psalm
cdc0144 
closes laminas-api-tools#16

Signed-off-by: Dmitriy Bespalov <dbespalov.rosko@gmail.com>
@weierophinney
qa: apply Psalm suggestions and create initial baseline
264990d 
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney merged commit faab0f5 into laminas-api-tools:1.4.x Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbundyra michalbundyra Awaiting requested review from michalbundyra

Assignees
No one assigned
Labels
Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Psalm integration
3 participants
@superrosko @boesing @weierophinney