Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG.md bump failed for branch with valid changelog? #57

Closed
Ocramius opened this issue Aug 18, 2020 · 8 comments · Fixed by #73
Closed

CHANGELOG.md bump failed for branch with valid changelog? #57

Ocramius opened this issue Aug 18, 2020 · 8 comments · Fixed by #73
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@Ocramius
Copy link
Member

Bug Report

See https://github.com/Ocramius/PackageVersions/actions/runs/213423994

Q A
Version(s) 1.2.4

Didn't manage to investigate further, but changelog commit seemed to fail due to no generated diff (by the changelog bump tool)

@Ocramius Ocramius added the Bug Something isn't working label Aug 18, 2020
@Ocramius Ocramius added this to the 1.2.5 milestone Aug 18, 2020
@Ocramius
Copy link
Member Author

More reproducers: https://github.com/Ocramius/PackageVersions/runs/997860158?check_suite_focus=true

Possibly my CHANGELOG.md being non-standard? Will probably consider dropping it completely, instead of pursuing (not important for me, given the release notes include the changelog anyway)

@weierophinney
Copy link
Member

One way to check your format is to use keep-a-changelog (we have a PHAR if that makes it easier for you to consume; check the releases pages), and run keep-a-changelog version:list; if it finds your versions, then try a keep-a-changelog version:show {version} and see if it can dump the contents. If either of those operations fail, then it's definitely the formatting that's the culprit.

@Ocramius Ocramius removed this from the 1.2.5 milestone Aug 31, 2020
@weierophinney
Copy link
Member

Is this resolved with the latest releases, @Ocramius ?

@Ocramius
Copy link
Member Author

Ocramius commented Sep 3, 2020

Haven't tried it yet - no changes in downstream happened for now

@kpicaza
Copy link

kpicaza commented Sep 5, 2020

I have the same issue trying the package, in my case the issue was the format of the release version title:

Normally I use github_changelog_generator, that generates the release version titles In the following format:

## [0.0.3](https://github.com/kpicaza/laminas-component-installer-test/tree/0.0.3) (2020-09-05)

Having the described error

image

Using the same format as https://keepachangelog.com/en/1.0.0/ example solves the issue.

## [0.0.3] - 2020-09-05

image

I'll expect it can help, thanks for your great work. ;-D

@ramsey
Copy link
Contributor

ramsey commented Sep 5, 2020

I think #73 fixes this. I'm fairly certain this is because phly/keep-a-changelog was failing to parse the content of CHANGELOG.md.

@Ocramius
Copy link
Member Author

Ocramius commented Sep 6, 2020

Closing here: please report again if it occurs after 1.8.0

@Ocramius Ocramius closed this as completed Sep 6, 2020
@Ocramius Ocramius added this to the 1.8.0 milestone Sep 6, 2020
@Ocramius Ocramius linked a pull request Sep 6, 2020 that will close this issue
@ramsey
Copy link
Contributor

ramsey commented Sep 7, 2020

I just tested this again on ramsey/devtools, and it worked!

The only hiccup I ran into was with protected branches; it was unable to push to a protected branch during the "Release" step. I turned off the protected branches, and ran it again, and it all went smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants