Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update phly/keep-a-changelog #73

Merged
merged 1 commit into from
Sep 6, 2020
Merged

fix: update phly/keep-a-changelog #73

merged 1 commit into from
Sep 6, 2020

Conversation

ramsey
Copy link
Contributor

@ramsey ramsey commented Sep 5, 2020

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

This is directly related to an issue I encountered where the release failed because my CHANGELOG.md was not in a recognizable format.

See here: https://github.com/ramsey/devtools/runs/1072810806?check_suite_focus=true#step:6:12

I submitted the following PR to phly/keep-a-changelog, which fixes the issue there: phly/keep-a-changelog#80

This commit updates phly/keep-a-changelog to v2.9.0, which includes the fix I submitted to that library:
https://github.com/phly/keep-a-changelog/releases/tag/2.9.0

This is directly related to an issue I encountered where the release
failed because my CHANGELOG.md was not in a recognizable format.

See here:
https://github.com/ramsey/devtools/runs/1072810806?check_suite_focus=true#step:6:12

I submitted the following PR to phly/keep-a-changelog, which fixes the
issue there: phly/keep-a-changelog#80

This commit updates phly/keep-a-changelog to v2.9.0, which includes the
fix I submitted to that library:
https://github.com/phly/keep-a-changelog/releases/tag/2.9.0

Signed-off-by: Ben Ramsey <ben@benramsey.com>
@Ocramius Ocramius added this to the 1.8.0 milestone Sep 6, 2020
@Ocramius Ocramius changed the base branch from 1.8.x to 1.7.x September 6, 2020 09:01
@Ocramius Ocramius modified the milestones: 1.8.0, 1.7.1 Sep 6, 2020
@Ocramius Ocramius self-assigned this Sep 6, 2020
@Ocramius Ocramius added the Bug Something isn't working label Sep 6, 2020
@Ocramius Ocramius modified the milestones: 1.7.1, 1.8.0 Sep 6, 2020
@Ocramius Ocramius changed the base branch from 1.7.x to 1.8.x September 6, 2020 09:02
@Ocramius
Copy link
Member

Ocramius commented Sep 6, 2020

Wanted to merge back into 1.7.x, but then this would've had conflicts due to CHANGELOG.md, therefore sticking to 1.8.0 and releasing

@Ocramius Ocramius merged commit a203a56 into laminas:1.8.x Sep 6, 2020
@Ocramius Ocramius linked an issue Sep 6, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHANGELOG.md bump failed for branch with valid changelog?
2 participants