Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bash wrapper for entrypoint #100

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Replace bash wrapper for entrypoint #100

merged 1 commit into from
Jan 24, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 24, 2021 •
edited by Ocramius
Loading

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA yes

Description

Replace bash wrapper for entrypoint, invoke console.php directly.

Solves two issues:

  • Update entrypoint for argument quoting so that word splitting does not lose spaces in arguments (see details in Update entrypoint for argument quoting #98)
  • Release memory from shell process. Besides releasing resources (memory), this is very important in docker containers so that signals get routed properly to PID=1.

@glensc
Replace bash wrapper for entrypoint
87c1b59 
Invoke console.php directly

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
@glensc glensc mentioned this pull request Jan 24, 2021
Closed
@Ocramius Ocramius added the Bug Something isn't working label Jan 24, 2021
@Ocramius Ocramius added this to the 1.9.1 milestone Jan 24, 2021
@Ocramius Ocramius self-assigned this Jan 24, 2021
@Ocramius
Copy link
Member

LGTM 👍

@Ocramius Ocramius merged commit c572192 into laminas:1.9.x Jan 24, 2021
@Ocramius
Copy link
Member

FWIW, smoke-tested it with https://github.com/Ocramius/LazyMap/runs/1758541072?check_suite_focus=true and works fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @Ocramius